Support for repeatable directives #412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be ready as graphql/graphql-js#1965 has landed in the reference implementation. |
nickhudkins
force-pushed
the
repeatable-directives
branch
from
bdaf476 to
1bc4663
Compare
|
I think this is a nice feature, but have never written a single line of Scala code in my life. I hope someone else gets to it - godspeed! |
yanns
approved these changes
Jan 27, 2021
|
@yanns since the https://www.apollographql.com/docs/federation/federation-spec/#federation-schema-specification contains repeatable directives, this might be the right motivation to merge this work? |
|
Repeatable directives are now in the spec: http://spec.graphql.org/October2021/#sec-Type-System.Directives |
|
As there are many conflicts to fix in this PR, I've opened a new one with about the same changes: #899 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge as soon as graphql/graphql-js#1541 is merged.
Closes #409