Remove Duplicated Dependencies and PEP 517 Support #2173

ChihweiLHBird · 2021-06-24T23:10:19Z

Many dependencies are in requirements but also in extras_require. So I think we can remove them from extras_require.
Add pyproject.toml, which is the "file be used to specify what program to use for generating distribution."
https://setuptools.readthedocs.io/en/latest/build_meta.html

ahopkins · 2021-06-25T04:51:31Z

A route I think I'd rather go down is to have some requirements files and read them into setup.py and tox.ini instead of duplicating them. Do you want to have a run at that?

ChihweiLHBird · 2021-06-25T06:21:34Z

A route I think I'd rather go down is to have some requirements files and read them into setup.py and tox.ini instead of duplicating them. Do you want to have a run at that?

How about put the requirements into the setup.cfg file instead of the requirements.txt file? Do you think is a good idea?

ahopkins · 2021-06-25T07:42:17Z

I'm not opposed. Any organization effort would be better.

ChihweiLHBird · 2021-06-25T19:28:52Z

I'm not opposed. Any organization effort would be better.

@ahopkins
I checked it, and it appears that we have dynamic dependencies manipulation (line 124-137) in setup.py, maybe leaving the requirements in setup.py is reasonable, because what we will put into the requirements.txt or setup.cfg, is not finalized requirements list. What do you think?

ahopkins · 2021-06-27T07:05:47Z

I would do something like this in setup.py:

allow_uvloop = see_existing_setup_py
allow_ujson = see_existing_setup_py

filters = (
    lambda x: x.startswith("#"),
    lambda x: x.startswith("uvloop") if not allow_uvloop else False,
    lambda x: x.startswith("ujson") if not allow_ujson else False,
)
def load_requirements(path_to_reqs):
    with open(path_to_reqs, "r") as f:
        reqs = [req.strip() for req in f.readlines() if not any(f(r) for f in filters)]
    return reqs

load_requirements("./requirements.txt")

ChihweiLHBird · 2021-06-27T10:03:32Z

I would do something like this in setup.py:

allow_uvloop = see_existing_setup_py
allow_ujson = see_existing_setup_py

filters = (
    lambda x: x.startswith("#"),
    lambda x: x.startswith("uvloop") if not allow_uvloop else False,
    lambda x: x.startswith("ujson") if not allow_ujson else False,
)
def load_requirements(path_to_reqs):
    with open(path_to_reqs, "r") as f:
        reqs = [req.strip() for req in f.readlines() if not any(f(r) for f in filters)]
    return reqs

load_requirements("./requirements.txt")

I think manually parse requirements.txt is okay if we don't have those extra requirements for tests, dev, and docs, but things get complicated since we have them. And the parse_requirements API by pip is now an internal API and we probably want to avoid using it. I tried pkg_resources.parse_requirements by setuptools but it does not parse sys_platform != win32 in my requirements.txt. So I would suggest using our current pattern of requirements list in setup.py.

requirements.txt

ujson>=1.35; sys_platform != win32 and implementation_name == cpython
uvloop>=0.5.3; sys_platform != win32 and implementation_name == cpython
sanic-routing==0.7.0rc1
httptools>=0.0.10
aiofiles>=0.6.0
websockets>=9.0
multidict>=5.0<6.0
sanic-testing[dev,test]>=0.6.0
pytest[dev,test]==5.2.1
gunicorn[dev,test]==20.0.4
pytest-cov[dev,test]
beautifulsoup4[dev,test]
pytest-sanic[dev,test]
pytest-sugar[dev,test]
pytest-benchmark[dev,test]
tox[dev]
black[dev]
isort[dev]
flake8[dev]
bandit[dev]
towncrier[dev]
sphinx[doc]>=2.1.2
sphinx_rtd_theme[doc]
recommonmark[doc]>=0.5.0
docutils[doc]
pygments[doc]

ahopkins · 2021-06-27T12:02:59Z

How well does it play with tox?

ChihweiLHBird · 2021-06-27T20:28:21Z

How well does it play with tox?

I only got Python 3.8 installed so tox didn't find other versions of Python. Is it necessary (or recommended) to install all of them and test it locally?

My environment for running it was Ubuntu WSL2 (Windows Subsystem for Linux 2).

______________________________________________________________________________________________ summary ______________________________________________________________________________________________
ERROR:  py37: InterpreterNotFound: python3.7
  py38: commands succeeded
ERROR:  py39: InterpreterNotFound: python3.9
  pyNightly: commands succeeded
ERROR:  pypy37: InterpreterNotFound: pypy3.7
ERROR:  py37-no-ext: InterpreterNotFound: python3.7
ERROR:   py38-no-ext: commands failed
ERROR:  py39-no-ext: InterpreterNotFound: python3.9
  pyNightly-no-ext: commands succeeded
ERROR:  pypy37-no-ext: InterpreterNotFound: pypy3.7
  lint: commands succeeded
  check: commands succeeded
  security: commands succeeded
  docs: commands succeeded
  type-checking: commands succeeded

ChihweiLHBird · 2021-06-27T21:28:01Z

How well does it play with tox?

I only got Python 3.8 installed so tox didn't find other versions of Python. Is it necessary (or recommended) to install all of them and test it locally?

My environment for running it was Ubuntu WSL2 (Windows Subsystem for Linux 2).

______________________________________________________________________________________________ summary ______________________________________________________________________________________________
ERROR:  py37: InterpreterNotFound: python3.7
  py38: commands succeeded
ERROR:  py39: InterpreterNotFound: python3.9
  pyNightly: commands succeeded
ERROR:  pypy37: InterpreterNotFound: pypy3.7
ERROR:  py37-no-ext: InterpreterNotFound: python3.7
ERROR:   py38-no-ext: commands failed
ERROR:  py39-no-ext: InterpreterNotFound: python3.9
  pyNightly-no-ext: commands succeeded
ERROR:  pypy37-no-ext: InterpreterNotFound: pypy3.7
  lint: commands succeeded
  check: commands succeeded
  security: commands succeeded
  docs: commands succeeded
  type-checking: commands succeeded

Ran it again and py38-no-ext became success... Not sure why.

___________________________________ summary ____________________________________
ERROR:  py37: InterpreterNotFound: python3.7
  py38: commands succeeded
ERROR:  py39: InterpreterNotFound: python3.9
  pyNightly: commands succeeded
ERROR:  pypy37: InterpreterNotFound: pypy3.7
ERROR:  py37-no-ext: InterpreterNotFound: python3.7
  py38-no-ext: commands succeeded
ERROR:  py39-no-ext: InterpreterNotFound: python3.9
  pyNightly-no-ext: commands succeeded
ERROR:  pypy37-no-ext: InterpreterNotFound: pypy3.7
  lint: commands succeeded
  check: commands succeeded
  security: commands succeeded
  docs: commands succeeded
  type-checking: commands succeeded

ChihweiLHBird · 2021-06-27T21:39:09Z

The error was:

=================================== FAILURES ===================================
________________________ test_keep_alive_client_timeout ________________________

    @pytest.mark.skipif(
        bool(environ.get("SANIC_NO_UVLOOP"))
        or OS_IS_WINDOWS
        or platform.system() != "Linux",
        reason="Not testable with current client",
    )
    def test_keep_alive_client_timeout():
        """If the server keep-alive timeout is longer than the client
        keep-alive timeout, client will try to create a new connection here."""
        try:
            loop = asyncio.new_event_loop()
            asyncio.set_event_loop(loop)
            client = ReuseableSanicTestClient(keep_alive_app_client_timeout, loop)
            headers = {"Connection": "keep-alive"}
            _, response = client.get("/1", headers=headers, request_keepalive=1)
    
            assert response.status == 200
            assert response.text == "OK"
    
            loop.run_until_complete(aio_sleep(2))
            _, response = client.get("/1", request_keepalive=1)
    
>           assert ReusableSanicConnectionPool.last_reused_connection is None
E           assert <AsyncHTTPConnection [HTTP/1.1, IDLE]> is None
E            +  where <AsyncHTTPConnection [HTTP/1.1, IDLE]> = ReusableSanicConnectionPool.last_reused_connection

I don't know how it is related my change, but since the second run is okay, I guess it is a random fail.

ahopkins · 2021-06-28T05:30:01Z

I only got Python 3.8 installed so tox didn't find other versions of Python. Is it necessary (or recommended) to install all of them and test it locally?

Nope, that's what CI is for 😎

I don't know how it is related my change, but since the second run is okay, I guess it is a random fail.

That test is sometimes a bit flappy. Testing the keep-alive is a bit tricky. I don't read much into that failure.

ChihweiLHBird · 2021-07-01T05:28:10Z

I only got Python 3.8 installed so tox didn't find other versions of Python. Is it necessary (or recommended) to install all of them and test it locally?

Nope, that's what CI is for 😎

I don't know how it is related my change, but since the second run is okay, I guess it is a random fail.

That test is sometimes a bit flappy. Testing the keep-alive is a bit tricky. I don't read much into that failure.

Thank you! So do you think we can merge these change? Is there anything that can be improved?

ahopkins · 2021-07-01T06:17:03Z

Thank you! So do you think we can merge these change? Is there anything that can be improved?

I think the last thing that really might be helpful is cleanup for tox since these are duplicated there. Something like this:

deps = .[test]

We then could duplicate the pattern for lint, docs, etc on the other tox environments. so that there is no more list of deps in tox also.

See: https://stackoverflow.com/a/41398850/1036843

ChihweiLHBird · 2021-07-01T07:42:50Z

Thank you! So do you think we can merge these change? Is there anything that can be improved?

I think the last thing that really might be helpful is cleanup for tox since these are duplicated there. Something like this:
deps = .[test]
We then could duplicate the pattern for lint, docs, etc on the other tox environments. so that there is no more list of deps in tox also.

See: https://stackoverflow.com/a/41398850/1036843

Thank you @ahopkins , let me take a look at that. There are some deps which are in tox.ini but not in setup.py's test extras requirements list. I think I would need to add them in setup.py.

ChihweiLHBird · 2021-07-03T22:47:21Z

@ahopkins Do we have any specific reason to set usedevelop to True in tox.ini? I found this option may cause the problem that dependencies won't be installed in some Python versions, if I let tox read extras dependencies from setup.py. I am wondering if I may remove this option.

ChihweiLHBird · 2021-07-04T00:00:55Z

Local tox output, seems successful.

___________________________________ summary ____________________________________
ERROR:  py37: InterpreterNotFound: python3.7
  py38: commands succeeded
ERROR:  py39: InterpreterNotFound: python3.9
  pyNightly: commands succeeded
ERROR:  pypy37: InterpreterNotFound: pypy3.7
ERROR:  py37-no-ext: InterpreterNotFound: python3.7
  py38-no-ext: commands succeeded
ERROR:  py39-no-ext: InterpreterNotFound: python3.9
  pyNightly-no-ext: commands succeeded
ERROR:  pypy37-no-ext: InterpreterNotFound: pypy3.7
  lint: commands succeeded
  check: commands succeeded
  security: commands succeeded
  docs: commands succeeded
  type-checking: commands succeeded

https://1drv.ms/t/s!Auf8Km0xmwewhflpgKbHeKHv2yipag?e=C3bFXg

ahopkins · 2021-07-04T01:49:42Z

@ahopkins Do we have any specific reason to set usedevelop to True in tox.ini? I found this option may cause the problem that dependencies won't be installed in some Python versions, if I let tox read extras dependencies from setup.py. I am wondering if I may remove this option.

it's the same as using -e. if it runs without it, then remove it.

ChihweiLHBird · 2021-07-04T05:48:48Z

@ahopkins Do we have any specific reason to set usedevelop to True in tox.ini? I found this option may cause the problem that dependencies won't be installed in some Python versions, if I let tox read extras dependencies from setup.py. I am wondering if I may remove this option.

it's the same as using -e. if it runs without it, then remove it.

@ahopkins Thank you! I think everything is good now. Can you trigger the CI and review this PR?

* Remove unnecessary import in test_constants.py, which also fixes an error on win (#2180) Co-authored-by: Adam Hopkins <admhpkns@gmail.com> * Manually reset the buffer when streaming request body (#2183) * Remove Duplicated Dependencies and PEP 517 Support (#2173) * Remove duplicated dependencies * Specify setuptools as the tool for generating distribution (PEP 517) * Add `isort` to `dev_require` * manage all dependencies in setup.py * Execute `make pretty` * Set usedevelop to true (revert previous change) * Fix the handling of the end of a chunked request. (#2188) * Fix the handling of the end of a chunked request. * Avoid hardcoding final chunk header size. * Add some unit tests for pipeline body reading * Decode bytes for json serialization Co-authored-by: L. Kärkkäinen <tronic@users.noreply.github.com> Co-authored-by: Adam Hopkins <adam@amhopkins.com> * Resolve regressions in exceptions (#2181) * Update sanic-routing to fix path issues plus lookahead / lookbehind support (#2178) * Update sanic-routing to fix path issues plus lookahead / lookbehind support * Update setup.py Co-authored-by: Adam Hopkins <adam@amhopkins.com> Co-authored-by: Adam Hopkins <admhpkns@gmail.com> * style(app,blueprints): add some type hints (#2196) * style(app,blueprints): add some type hints * style(app): option is Any * style(blueprints): url prefix default value is ``""`` * style(app): backward compatible * style(app): backward compatible * style(blueprints): defult is None * style(app): apply code style (black) * Update some CC config (#2199) * Update README.rst * raise exception for `_static_request_handler` unknown exception; add test with custom error (#2195) Co-authored-by: n.feofanov <n.feofanov@visionlabs.ru> Co-authored-by: Adam Hopkins <admhpkns@gmail.com> * Change dumps to AnyStr (#2193) * HTTP tests (#2194) * Fix issues with after request handling in HTTP pipelining (#2201) * Clean up after a request is complete, before the next pipelined request. * Limit the size of request body consumed after handler has finished. * Linter error. * Add unit test re: bad headers Co-authored-by: L. Kärkkäinen <tronic@users.noreply.github.com> Co-authored-by: Adam Hopkins <admhpkns@gmail.com> Co-authored-by: Adam Hopkins <adam@amhopkins.com> * Update CHANGELOG * Log remote address if available (#2207) * Log remote address if available * Add tests * Fix testing version Co-authored-by: Adam Hopkins <adam@amhopkins.com> * Fixed for handling exceptions of asgi app call. (#2211) @cansarigol3megawatt Thanks for looking into this and getting the quick turnaround on this. I will 🍒 pick this into the 21.6 branch and get it out a little later tonight. * Signals Integration (#2160) * Update some tests * Resolve #2122 route decorator returning tuple * Use rc sanic-routing version * Update unit tests to <:str> * Minimal working version with some signals implemented * Add more http signals * Update ASGI and change listeners to signals * Allow for dynamic ODE signals * Allow signals to be stacked * Begin tests * Prioritize match_info on keyword argument injection * WIP on tests * Compat with signals * Work through some test coverage * Passing tests * Post linting * Setup proper resets * coverage reporting * Fixes from vltr comments * clear delayed tasks * Fix bad test * rm pycache * uncomment windows tests (#2214) * Add convenience methods to BP groups (#2209) * Fix bug where ws exceptions not being logged (#2213) * Fix bug where ws exceptions not being logged * Fix t\est * Style: add type hints (#2217) * style(routes): add_route argument, return typing * style(listeners): typing * style(views): typing as_view * style(routes): change type hint * style(listeners): change type hint * style(routes): change type hint * add some more types * Change as_view typing * Add some cleaner type annotations Co-authored-by: Adam Hopkins <adam@amhopkins.com> * Add default messages to SanicExceptions (#2216) * Add default messages to SanicExceptions * Cleaner exception message setting * Copy Blueprints Implementation (#2184) * Accept header parsing (#2200) * Add some tests * docstring * Add accept matching * Add some more tests on matching * Add matching flags for wildcards * Add mathing controls to accept * Limit uvicorn 14 in testing * Add convenience for annotated handlers (#2225) * Split HttpProtocol parts into base SanicProtocol and HTTPProtocol subclass (#2229) * Split HttpProtocol parts into base SanicProtocol and HTTPProtocol subclass. * lint fixes * re-black server.py * Move server.py into its own module (#2230) * Move server.py into its own module * Change monkeypatch path on test_logging.py * Blueprint specific exception handlers (#2208) * Call abort() on sockets after close() to prevent dangling sockets (#2231) * Add ability to return Falsey but not-None from handlers (#2236) * Adds Blueprint Group exception decorator (#2238) * Add exception decorator * Added tests * Fix line too long * Static DIR and FILE resource types (#2244) * Explicit static directive for serving file or dir Co-authored-by: anbuhckr <36891836+anbuhckr@users.noreply.github.com> Co-authored-by: anbuhckr <miki.suhendra@gmail.com> * Close HTTP loop when connection task cancelled (#2245) * Terminate loop when no transport exists * Add log when closing HTTP loop because of shutdown * Add unit test * New websockets (#2158) * First attempt at new Websockets implementation based on websockets >= 9.0, with sans-i/o features. Requires more work. * Update sanic/websocket.py Co-authored-by: Adam Hopkins <adam@amhopkins.com> * Update sanic/websocket.py Co-authored-by: Adam Hopkins <adam@amhopkins.com> * Update sanic/websocket.py Co-authored-by: Adam Hopkins <adam@amhopkins.com> * wip, update websockets code to new Sans/IO API * Refactored new websockets impl into own modules Incorporated other suggestions made by team * Another round of work on the new websockets impl * Added websocket_timeout support (matching previous/legacy support) * Lots more comments * Incorporated suggested changes from previous round of review * Changed RuntimeError usage to ServerError * Changed SanicException usage to ServerError * Removed some redundant asserts * Change remaining asserts to ServerErrors * Fixed some timeout handling issues * Fixed websocket.close() handling, and made it more robust * Made auto_close task smarter and more error-resilient * Made fail_connection routine smarter and more error-resilient * Further new websockets impl fixes * Update compatibility with Websockets v10 * Track server connection state in a more precise way * Try to handle the shutdown process more gracefully * Add a new end_connection() helper, to use as an alterative to close() or fail_connection() * Kill the auto-close task and keepalive-timeout task when sanic is shutdown * Deprecate WEBSOCKET_READ_LIMIT and WEBSOCKET_WRITE_LIMIT configs, they are not used in this implementation. * Change a warning message to debug level Remove default values for deprecated websocket parameters * Fix flake8 errors * Fix a couple of missed failing tests * remove websocket bench from examples * Integrate suggestions from code reviews Use Optional[T] instead of union[T,None] Fix mypy type logic errors change "is not None" to truthy checks where appropriate change "is None" to falsy checks were appropriate Add more debug logging when debug mode is on Change to using sanic.logger for debug logging rather than error_logger. * Fix long line lengths of debug messages Add some new debug messages when websocket IO is paused and unpaused for flow control Fix websocket example to use app.static() * remove unused import in websocket example app * re-run isort after Flake8 fixes Co-authored-by: Adam Hopkins <adam@amhopkins.com> Co-authored-by: Adam Hopkins <admhpkns@gmail.com> * Account for BP with exception handler but no routes (#2246) * Don't log "enabled" if auto-reload disabled (#2247) Fixes #2240 Co-authored-by: Adam Hopkins <admhpkns@gmail.com> * Smarter auto fallback (#2162) * Smarter auto fallback * remove config from blueprints * Add tests for error formatting * Add check for proper format * Fix some tests * Add some tests * docstring * Add accept matching * Add some more tests on matching * Fix contains bug, earlier return on MediaType eq * Add matching flags for wildcards * Add mathing controls to accept * Cleanup dev cruft * Add cleanup and resolve OSError relating to test implementation * Fix test * Fix some typos * Some fixes to the new Websockets impl (#2248) * First attempt at new Websockets implementation based on websockets >= 9.0, with sans-i/o features. Requires more work. * Update sanic/websocket.py Co-authored-by: Adam Hopkins <adam@amhopkins.com> * Update sanic/websocket.py Co-authored-by: Adam Hopkins <adam@amhopkins.com> * Update sanic/websocket.py Co-authored-by: Adam Hopkins <adam@amhopkins.com> * wip, update websockets code to new Sans/IO API * Refactored new websockets impl into own modules Incorporated other suggestions made by team * Another round of work on the new websockets impl * Added websocket_timeout support (matching previous/legacy support) * Lots more comments * Incorporated suggested changes from previous round of review * Changed RuntimeError usage to ServerError * Changed SanicException usage to ServerError * Removed some redundant asserts * Change remaining asserts to ServerErrors * Fixed some timeout handling issues * Fixed websocket.close() handling, and made it more robust * Made auto_close task smarter and more error-resilient * Made fail_connection routine smarter and more error-resilient * Further new websockets impl fixes * Update compatibility with Websockets v10 * Track server connection state in a more precise way * Try to handle the shutdown process more gracefully * Add a new end_connection() helper, to use as an alterative to close() or fail_connection() * Kill the auto-close task and keepalive-timeout task when sanic is shutdown * Deprecate WEBSOCKET_READ_LIMIT and WEBSOCKET_WRITE_LIMIT configs, they are not used in this implementation. * Change a warning message to debug level Remove default values for deprecated websocket parameters * Fix flake8 errors * Fix a couple of missed failing tests * remove websocket bench from examples * Integrate suggestions from code reviews Use Optional[T] instead of union[T,None] Fix mypy type logic errors change "is not None" to truthy checks where appropriate change "is None" to falsy checks were appropriate Add more debug logging when debug mode is on Change to using sanic.logger for debug logging rather than error_logger. * Fix long line lengths of debug messages Add some new debug messages when websocket IO is paused and unpaused for flow control Fix websocket example to use app.static() * remove unused import in websocket example app * re-run isort after Flake8 fixes * Some fixes to the new Websockets impl Will throw WebsocketClosed exception instead of ServerException now when attempting to read or write to closed websocket, this makes it easier to catch The various ws.recv() methods now have the ability to raise CancelledError into your websocket handler Fix a niche close-socket negotiation bug Fix bug where http protocol thought the websocket never sent any response. Allow data to still send in some cases after websocket enters CLOSING state. Fix some badly formatted and badly placed comments * allow eof_received to send back data too, if the connection is in CLOSING state Co-authored-by: Adam Hopkins <adam@amhopkins.com> Co-authored-by: Adam Hopkins <admhpkns@gmail.com> * 21.9 release docs (#2218) * Beging 21.9 release docs * Add PRs to changelog * Change deprecation version * Update logging tests * Bump version * Update changelog * Change dev install command (#2251) Co-authored-by: Zhiwei <zhi.wei.liang@outlook.com> Co-authored-by: L. Kärkkäinen <98187+Tronic@users.noreply.github.com> Co-authored-by: L. Kärkkäinen <tronic@users.noreply.github.com> Co-authored-by: Robert Palmer <robd003@users.noreply.github.com> Co-authored-by: Ryu JuHeon <saidbysolo@gmail.com> Co-authored-by: gluhar2006 <49654448+gluhar2006@users.noreply.github.com> Co-authored-by: n.feofanov <n.feofanov@visionlabs.ru> Co-authored-by: Néstor Pérez <25409753+prryplatypus@users.noreply.github.com> Co-authored-by: Can Sarigol <56863826+cansarigol3megawatt@users.noreply.github.com> Co-authored-by: Zhiwei <chihwei.public@outlook.com> Co-authored-by: YongChan Cho <h3236516@gmail.com> Co-authored-by: Zhiwei <zhiwei@sinatra.ai> Co-authored-by: Ashley Sommer <ashleysommer@gmail.com> Co-authored-by: anbuhckr <36891836+anbuhckr@users.noreply.github.com> Co-authored-by: anbuhckr <miki.suhendra@gmail.com>

* Remove duplicated dependencies * Specify setuptools as the tool for generating distribution (PEP 517) * Add `isort` to `dev_require` * manage all dependencies in setup.py * Execute `make pretty` * Set usedevelop to true (revert previous change)

Remove duplicated dependencies

7a500ca

ChihweiLHBird requested a review from a team as a code owner June 24, 2021 23:10

Specify setuptools as the tool for generating distribution (PEP 517)

13373d2

ChihweiLHBird changed the title ~~Remove duplicated dependencies~~ Remove Duplicated Dependencies and PEP 517 Support Jun 25, 2021

Add isort to dev_require

1433b7b

Merge branch 'main' into zhiwei/remove-duplicate-depen

c11a6a8

manage all dependencies in setup.py

1b2cb7e

ChihweiLHBird requested a review from a team as a code owner July 3, 2021 23:03

Execute make pretty

fc618cc

Set usedevelop to true (revert previous change)

c7a31e4

ChihweiLHBird added 2 commits July 5, 2021 02:05

Merge branch 'main' into zhiwei/remove-duplicate-depen

5e2abd8

Merge branch 'main' into zhiwei/remove-duplicate-depen

35f4bd3

ahopkins approved these changes Jul 8, 2021

View reviewed changes

ahopkins merged commit 1dd0332 into sanic-org:main Jul 8, 2021

ChihweiLHBird deleted the zhiwei/remove-duplicate-depen branch July 8, 2021 08:49

ahopkins mentioned this pull request Sep 30, 2021

21.9 release docs #2218

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Duplicated Dependencies and PEP 517 Support #2173

Remove Duplicated Dependencies and PEP 517 Support #2173

ChihweiLHBird commented Jun 24, 2021 •

edited

Loading

ahopkins commented Jun 25, 2021

ChihweiLHBird commented Jun 25, 2021

ahopkins commented Jun 25, 2021

ChihweiLHBird commented Jun 25, 2021

ahopkins commented Jun 27, 2021

ChihweiLHBird commented Jun 27, 2021

ahopkins commented Jun 27, 2021

ChihweiLHBird commented Jun 27, 2021

ChihweiLHBird commented Jun 27, 2021

ChihweiLHBird commented Jun 27, 2021 •

edited

Loading

ahopkins commented Jun 28, 2021 •

edited

Loading

ChihweiLHBird commented Jul 1, 2021

ahopkins commented Jul 1, 2021

ChihweiLHBird commented Jul 1, 2021

ChihweiLHBird commented Jul 3, 2021

ChihweiLHBird commented Jul 4, 2021

ahopkins commented Jul 4, 2021

ChihweiLHBird commented Jul 4, 2021

Remove Duplicated Dependencies and PEP 517 Support #2173

Remove Duplicated Dependencies and PEP 517 Support #2173

Conversation

ChihweiLHBird commented Jun 24, 2021 • edited Loading

ahopkins commented Jun 25, 2021

ChihweiLHBird commented Jun 25, 2021

ahopkins commented Jun 25, 2021

ChihweiLHBird commented Jun 25, 2021

ahopkins commented Jun 27, 2021

ChihweiLHBird commented Jun 27, 2021

ahopkins commented Jun 27, 2021

ChihweiLHBird commented Jun 27, 2021

ChihweiLHBird commented Jun 27, 2021

ChihweiLHBird commented Jun 27, 2021 • edited Loading

ahopkins commented Jun 28, 2021 • edited Loading

ChihweiLHBird commented Jul 1, 2021

ahopkins commented Jul 1, 2021

ChihweiLHBird commented Jul 1, 2021

ChihweiLHBird commented Jul 3, 2021

ChihweiLHBird commented Jul 4, 2021

ahopkins commented Jul 4, 2021

ChihweiLHBird commented Jul 4, 2021

ChihweiLHBird commented Jun 24, 2021 •

edited

Loading

ChihweiLHBird commented Jun 27, 2021 •

edited

Loading

ahopkins commented Jun 28, 2021 •

edited

Loading