Handle case when headers argument of ResponseStream constructor is None
#2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamcoatman
changed the title
Noneheaders argument of ResponseStream constructor is None
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2729 +/- ##
=============================================
- Coverage 88.981% 88.884% -0.098%
=============================================
Files 92 92
Lines 6979 6981 +2
Branches 1190 1191 +1
=============================================
- Hits 6210 6205 -5
- Misses 527 531 +4
- Partials 242 245 +3
☔ View full report in Codecov by Sentry. |
ahopkins
reviewed
Mar 30, 2023
|
@ahopkins I've added a test, which was failing prior to my fix and is now passing. I've probably put it in the wrong place, so let me know if you want me to move it. |
|
It's a long file, but I'd dump it here: https://github.com/sanic-org/sanic/blob/main/tests/test_response.py |
|
In case you missed it, I moved the test to |
prryplatypus
approved these changes
Apr 5, 2023
|
ResponseStream is not stream,bug? |
Sorry, I don't understand your question. |
ahopkins
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for the
headersargument isNone. This leads to an Exception whenheadersis passed to theHeaderconstructor, which is expecting a Mapping type.