Add loop argument to signal router finalize method to finalize without having a running loop

[eelkevdbos]

Closes #2829

[ahopkins]

😎 Nice. Thanks for raising the issue and making the fix.

I did not look at the reason for the failing tests, but I would guess it is a formatting thing.

There should be a command in the Makefile to run black across the repo.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a5a9658) 88.387% compared to head (e6e31d0) 88.429%.

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #2830       +/-   ##
=============================================
+ Coverage   88.387%   88.429%   +0.041%     
=============================================
  Files           92        92               
  Lines         7156      7156               
  Branches      1228      1228               
=============================================
+ Hits          6325      6328        +3     
+ Misses         575       574        -1     
+ Partials       256       254        -2     

Files	Coverage Δ
sanic/signals.py	91.549% <100.000%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eelkevdbos]

@ahopkins I've updated the formatting and doc blocks, but a seemingly unrelated test is failing. Is this test perhaps also failing on main or do I need to dig deeper into the issue?

[Tronic]

I gather you should use asyncio to set the loop or otherwise execute within its normal bounds, rather than passing loop arguments. It is worth noting that asyncio itself just went though a removal of loop argument passing.

[eelkevdbos]

I gather you should use asyncio to set the loop or otherwise execute within its normal bounds, rather than passing loop arguments. It is worth noting that asyncio itself just went though a removal of loop argument passing.

@Tronic Do you object merging this and suggest injecting the loop differently? I'm happy to go a different route, but provided PR at least works fine in my use case (#2829). The failing test seems an artifact from a failing main branch test (https://github.com/sanic-org/sanic/actions/runs/6109680961/job/16624825220).

@ahopkins Just as a sanity check, I can't see any uses of the self.ctx.loop when doing a search for references. Does the finalize method use the loop somewhere? Or is it being set up here for later use in the signal router lifecycle?

[Tronic]

Can you use asyncio.set_event_loop(loop) for that?