-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pathlib update to TLS #2840
base: main
Are you sure you want to change the base?
Pathlib update to TLS #2840
Conversation
…w both them and str are accepted.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2840 +/- ##
=============================================
+ Coverage 88.387% 88.430% +0.043%
=============================================
Files 92 92
Lines 7156 7157 +1
Branches 1228 1228
=============================================
+ Hits 6325 6329 +4
+ Misses 575 574 -1
+ Partials 256 254 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some tests.
Allows using pathlib paths for TLS certificate directories and cert/key filenames. Previously only
str
was accepted onapp.run(ssl=...)
.