-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed mixins.startup.serve
UnboundLocalError.
#2992
base: main
Are you sure you want to change the base?
Conversation
7f02bc3
to
fe55023
Compare
There do not seem to be existing tests that specifically test the functionality of |
fe55023
to
aad408a
Compare
mixins.startup.serve
UnboundLocalError.
9ddf8bd
to
6d80c7e
Compare
6d80c7e
to
0d7b2ae
Compare
Type error being raised by CI by line 724 of Same for the 8 other mypy type-check errors. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2992 +/- ##
=============================================
- Coverage 87.617% 87.451% -0.167%
=============================================
Files 101 101
Lines 7575 7666 +91
Branches 1329 1350 +21
=============================================
+ Hits 6637 6704 +67
- Misses 641 661 +20
- Partials 297 301 +4 ☔ View full report in Codecov by Sentry. |
Fixes #2985
the
finally
block inmixins.serve
references a variable that is only defined in thetry
block. This results in aUnboundLocalError
within thefinally
block.