Add tooltips #2
Merged
Add tooltips #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tronic
reviewed
Feb 6, 2023
Tronic
reviewed
Feb 6, 2023
Tronic
reviewed
Feb 6, 2023
Comment on lines
146
to
151
| cls = next( | ||
| v.__class__ if n == 'self' else v | ||
| for n, v in frame.f_locals.items() | ||
| if n in ('self', 'cls') | ||
| if n in ('self', 'cls') and v is not None | ||
| ) | ||
| function = f'{cls.__name__}.{function}' |
There was a problem hiding this comment.
What does this change address? A comment in code might be useful.
There was a problem hiding this comment.
One of the uvloop tabs showed: NoneType.run instead of just run
There was a problem hiding this comment.
It would appear to be a case with non-Python code then.
Tronic
reviewed
Feb 6, 2023
Tronic
reviewed
Feb 6, 2023
|
Note that packages installed in editable mode are considered user code. This might affect what gets hidden, where the auto-scroll lands and affect the warning sign. If you have sanic installed normally, it might produce different results than what you get in editable install. The warning sign shows the location where user code calls site-packages code (external library) that raises. |
Tronic
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tooltips to the marked lines for explanation.