Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[URGENT][TODO] Move away from Heroku by Nov 28, 2022 #29

Open
webknjaz opened this issue Aug 31, 2022 · 21 comments
Open

[URGENT][TODO] Move away from Heroku by Nov 28, 2022 #29

webknjaz opened this issue Aug 31, 2022 · 21 comments
Assignees

Comments

@webknjaz
Copy link
Member

webknjaz commented Aug 31, 2022

Apparently, they are sunsetting the free tier.

Fund with Polar
@webknjaz webknjaz pinned this issue Sep 27, 2022
@webknjaz
Copy link
Member Author

@webknjaz webknjaz self-assigned this Oct 19, 2022
@webknjaz webknjaz changed the title [URGENT][TODO] Move away from Heroku [URGENT][TODO] Move away from Heroku by Nov 28, 2022 Oct 19, 2022
@ekohl
Copy link

ekohl commented Nov 22, 2022

FYI: Foreman runs an octomachinery-backed app on OpenShift. In https://github.com/theforeman/prprocessor#deployment-using-openshift I documented the steps. It may be possible to set a GH secret in another way, but those steps at least got me going. If you need more, feel free to reach out to me.

@webknjaz
Copy link
Member Author

@ekohl thanks, I'll take a look! I've got access to a RH-sponsored instance years ago, but it was hard to get a newer Python there back then. Need to go through DO180 to get up to speed...

@webknjaz
Copy link
Member Author

webknjaz commented Dec 1, 2022

So I moved the bots on Nov 28, but wanted to go through some official s2i template examples that I researched years ago. I haven't moved back then, because there were no images in the image stream supporting Python 3.7, and I couldn't figure out how to change that.
The openshift cluster I got still doesn't have newer images, supposedly because it was created ~3 years ago, so it's still v3.
Anyway, I've figured out how to use an external image and got it working. So I'm hoping to publish that template at some point.

@webknjaz
Copy link
Member Author

webknjaz commented Dec 2, 2022

@ekohl one thing I haven't solved is TLS — did you figure out having HTTPS on a dedicated domain with Let's Encrypt?

@ekohl
Copy link

ekohl commented Dec 2, 2022

The instance we're on has a wildcard certificate for the domain it manages so we don't use a dedicated domain, just the one we got assigned. Since only GH connects to it I'd say a dedicated domain doesn't make sense.

Perhaps @evgeni remembers better how we set it up.

@evgeni
Copy link

evgeni commented Dec 2, 2022

Yeah, we just have our app configured with https://<funny-long-name>.openshiftapps.com/ and that has a valid cert issued by LE.
We didn't bother to try to host it on our domain.

@webknjaz
Copy link
Member Author

webknjaz commented Dec 2, 2022

Ah, too bad. It seems like my instance is also set up to drop the <funny-long-name> route (despite it being listed in the UI) from the setup so it doesn't even work when I have another route connected via CNAME.

@evgeni
Copy link

evgeni commented Dec 2, 2022

Is that a setup provided by osci.io or something else?

@webknjaz
Copy link
Member Author

webknjaz commented Dec 2, 2022

I don't think so, I don't remember exactly since I got it years ago, but my console is at https://console.rh-us-east-1.openshift.com.

@evgeni
Copy link

evgeni commented Dec 2, 2022

Okay,

Ours is at https://openshift-console.osci.io/ so definitely a different setup

@webknjaz
Copy link
Member Author

webknjaz commented Dec 2, 2022

Interesting, I can log in there too. I wonder if I can just start using it 🤔

webknjaz added a commit to sanitizers/chronographer-github-app that referenced this issue Mar 8, 2023
@ekohl
Copy link

ekohl commented Mar 13, 2023

Should this now be closed? It's still a pinned issue.

@webknjaz
Copy link
Member Author

@ekohl I'd like to have some config-as-code committed into the repo before closing this issue. Also, apparently, the OpenShift Online Employee cluster reaches EOL on October 16, 2023 and I have to migrate again.

So I'll be trying out the same cluster that you're using — OSCI (not sure if I need to ask for permission as it let's me in with the RH email but doesn't allow any other gsuite/gmail accounts).

I saw that @duck-rh seems to be involved there, so I'll try asking him...

P.S. Another prerequisite of closing this is having a proper TLS setup on a custom domain.

@evgeni
Copy link

evgeni commented Sep 27, 2023

When I last tried SSL with a custom domain on OSCI it wasn't really successful.

You could also try fly.io, assuming their free tier is sufficient for your setup. (https://fly.io/docs/about/pricing/)

@webknjaz
Copy link
Member Author

I was looking into it in a different context and will probably try it out if OSCI doesn't work.

@duck-rh
Copy link

duck-rh commented Sep 29, 2023

@evgeni The situation with Let's Encrypt certs on Openshift is evolving and at some point we'll need to change how we do it but that's rather complicated (Misc looked into it into more details). Anyway we have been able to generate web certs so far, and I'm not aware of your specific problem; did you discuss it with Misc already? Maybe we can help?

@webknjaz we can provide a namespace on our cluster. Ping me and we can set this up.

@ekohl
Copy link

ekohl commented Sep 29, 2023

We (theforeman) run our prprocessor on OSCI and it simply uses the provided domain name. That instance is set up using a wildcard certificate and that works well.

@webknjaz
Copy link
Member Author

@duck-rh the TLS problem is that when a route is added in openshift with a custom domain, it still serves the TLS certificate with own domain wildcard that doesn't list that custom domain.

@ekohl
Copy link

ekohl commented Oct 2, 2023

@webknjaz that's why I chose to not use a custom domain. It's just the GitHub -> App communication, so using the platform provided name was fine for us. Users don't see it anyway and it solved the TLS issue (because the wildcard cert was valid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants