fix(deps): Revert axios v1 bump in #185 #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks! |
Contributor
|
🎉 This PR is included in version 7.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the changes that were merged between
gatsby-source-sanity7.5.1 and 7.6.0 is a major version bump for axios (v0 to v1) in #185.Was able to reproduce the behavior shown in #200 via https://github.com/taulal/gatsby-source-sanity-bug-repo and fix it by adding a resolution that pins axios to v0 again.
Briefly looked for some direction from axios about what would need to change in
getDocumentStreamto make it work with the new axios major, but the renovate bot diff covers too much ground and there is no migration guide yet.For now then reverting and releasing a patch might be the best way to go about it.
I didn't find any tests that would cover this case, so please point me in that direction if I should add any. Otherwise running https://github.com/tyhopp/gatsby-source-sanity-bug-repo locally could work to verify the fix.
Fixes #200