Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typeEvaluator): avoid recalculating typeNode hash #278

Merged
merged 1 commit into from
Mar 10, 2025
Merged

fix(typeEvaluator): avoid recalculating typeNode hash #278

merged 1 commit into from
Mar 10, 2025

Conversation

sgulseth
Copy link
Member

@sgulseth sgulseth commented Mar 8, 2025 •
edited
Loading

Slow query+schema now takes <1s to evaluate, instead of the reported 30m(!)🙃

@sgulseth sgulseth marked this pull request as draft March 8, 2025 00:47
@sgulseth sgulseth marked this pull request as ready for review March 8, 2025 00:52
@sgulseth sgulseth requested review from judofyr and a team March 8, 2025 00:52
@sgulseth sgulseth force-pushed the fix/cldx-3149/hash-optimizations branch from f510208 to affd6b3 Compare March 8, 2025 00:56
judofyr
judofyr approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@judofyr judofyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, but would prefer a wrapper function to keep the core logic independent of the caching.

@sgulseth sgulseth force-pushed the fix/cldx-3149/hash-optimizations branch from affd6b3 to 6a057f2 Compare March 10, 2025 09:33
@sgulseth sgulseth force-pushed the fix/cldx-3149/hash-optimizations branch from 6a057f2 to d199f35 Compare March 10, 2025 09:34
@sgulseth sgulseth enabled auto-merge (rebase) March 10, 2025 09:39
@sgulseth sgulseth disabled auto-merge March 10, 2025 09:48
@sgulseth sgulseth merged commit 557fb89 into main Mar 10, 2025
6 checks passed
@sgulseth sgulseth deleted the fix/cldx-3149/hash-optimizations branch March 10, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@judofyr judofyr judofyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgulseth @judofyr