Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove node.import ESM CJS wrapper support #226

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Sep 5, 2023

Relates to sanity-io/client#318 and sanity-io/client#627

Caution

The ES Module wrapper pattern is now considered harmful.

@stipsan stipsan requested a review from a team as a code owner September 5, 2023 18:59
@stipsan stipsan force-pushed the remove-`node.module`-recommendation branch 3 times, most recently from 0151b2a to 1c73247 Compare October 4, 2023 12:31
@stipsan stipsan force-pushed the remove-`node.module`-recommendation branch 4 times, most recently from b8bbca3 to d481e4a Compare March 7, 2024 18:12
@stipsan stipsan changed the title fix: remove node.module recommendation feat: remove node.import ESM CJS wrapper support Mar 7, 2024
@stipsan stipsan force-pushed the remove-`node.module`-recommendation branch from d481e4a to 5d57a42 Compare March 7, 2024 18:20
@stipsan stipsan force-pushed the remove-`node.module`-recommendation branch from 5d57a42 to dca3a3b Compare March 7, 2024 18:24
@stipsan stipsan merged commit 28aa84d into main Mar 7, 2024
9 checks passed
@stipsan stipsan deleted the remove-`node.module`-recommendation branch March 7, 2024 18:28
@ecospark ecospark bot mentioned this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant