fix: prevent removal of last character on no filename extension #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sanity-io/client#98 If a file is uploaded with an original filename that does not include an extension (`.png` or similar), the `getFilenameWithoutExtension` method will remove the last character of the filename, because it uses the last index of `.`, which is not found, resulting in `-1`.
|
Thanks @rexxars! This highlighted a flaw with how this plugin displayed file extensions – the filename field input used the uploaded asset's Conflating the resolved extension and the original filename in this way resulted in weird visual issues, especially when uploading files with mismatched or empty extensions. That's now been simplified, we just render the filename in full and don't try and be cute with it! |
robinpyon
approved these changes
Feb 3, 2023
|
🎉 This PR is included in version 2.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sanity-io/client#98
If a file is uploaded with an original filename that does not include an extension (
.pngor similar), thegetFilenameWithoutExtensionmethod will remove the last character of the filename. This is caused by usinglastIndexOf('.'), which in the case of no.being present returns-1.Theoretically you might still have odd results if you upload files with filename such as
some.non.extension, which would result insome.non- but this is a bit of an edge case. Not sure what the best way of approach that would be - compare the extension (if present) with the mime type or generated asset filename?