Skip to content

Commit

Permalink
fix(form): always return SanityPreview in `defaultResolvePreviewCom…
Browse files Browse the repository at this point in the history
…ponent` since `SanityPreview` takes care of resolving the preview component
  • Loading branch information
hermanwikner authored and rexxars committed Sep 14, 2022
1 parent f0e18d1 commit 88363f9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
2 changes: 1 addition & 1 deletion packages/sanity/src/form/studio/defaults.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ export const defaultRenderItem: RenderItemCallback = (props) => {
}

export const defaultRenderPreview: RenderPreviewCallback = (props) => {
return createElement(defaultResolvePreviewComponent(props.schemaType), props)
return createElement(defaultResolvePreviewComponent(), props)
}
13 changes: 4 additions & 9 deletions packages/sanity/src/form/studio/inputResolver/inputResolver.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ import * as is from '../../utils/is'
import {FormField, FormFieldSet} from '../../components/formField'
import {PreviewProps} from '../../../components/previews'
import {SanityPreview} from '../../../preview'
import {isObjectField} from '../../utils/asserters'
import {ChangeIndicator} from '../../../components/changeIndicators'
import {resolveReferenceInput} from './resolveReferenceInput'
import {resolveArrayInput} from './resolveArrayInput'
import {resolveStringInput} from './resolveStringInput'
import {resolveNumberInput} from './resolveNumberInput'
import {defaultInputs} from './defaultInputs'
import {getArrayFieldLevel, getObjectFieldLevel} from './helpers'
import {isObjectField} from '../../utils/asserters'
import {ChangeIndicator} from '../../../components/changeIndicators'

function resolveComponentFromTypeVariants(
type: SchemaType
Expand Down Expand Up @@ -191,11 +191,6 @@ export function defaultResolveItemComponent(
return NoopField
}

// TODO: add PreviewProps interface
export function defaultResolvePreviewComponent(
schemaType: SchemaType
): React.ComponentType<PreviewProps> {
if (schemaType.components?.preview) return schemaType.components.preview

return SanityPreview as any // TODO
export function defaultResolvePreviewComponent(): React.ComponentType<PreviewProps> {
return SanityPreview as any
}

0 comments on commit 88363f9

Please sign in to comment.