fix: warnings on React 19 (#7654)

sanity-io · Oct 22, 2024 · 9c72c74 · 9c72c74
1 parent 5452e3d
commit 9c72c74
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/dev/test-next-studio/next-env.d.ts b/dev/test-next-studio/next-env.d.ts
@@ -2,4 +2,4 @@
 /// <reference types="next/image-types/global" />
 
 // NOTE: This file should not be edited
-// see https://nextjs.org/docs/basic-features/typescript for more information.
+// see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information.
diff --git a/packages/sanity/src/core/components/commandList/CommandList.tsx b/packages/sanity/src/core/components/commandList/CommandList.tsx
@@ -4,6 +4,8 @@ import {throttle} from 'lodash'
 import {
   cloneElement,
   forwardRef,
+  Fragment,
+  isValidElement,
   type ReactElement,
   useCallback,
   useEffect,
@@ -612,9 +614,14 @@ export const CommandList = forwardRef<CommandListHandle, CommandListProps>(funct
               virtualIndex,
             }) as ReactElement
 
-            const clonedItem = cloneElement(itemToRender, {
-              tabIndex: -1,
-            })
+            const clonedItem = cloneElement(
+              itemToRender,
+              isValidElement(itemToRender) && itemToRender.type == Fragment
+                ? {}
+                : {
+                    tabIndex: -1,
+                  },
+            )
 
             const activeAriaAttributes =
               typeof activeIndex === 'number' && !disabled
@@ -655,3 +662,4 @@ export const CommandList = forwardRef<CommandListHandle, CommandListProps>(funct
     </VirtualListBox>
   )
 })
+CommandList.displayName = 'ForwardRef(CommandList)'
diff --git a/packages/sanity/src/core/studio/components/navbar/resources/ResourcesMenuItems.tsx b/packages/sanity/src/core/studio/components/navbar/resources/ResourcesMenuItems.tsx
@@ -99,7 +99,7 @@ function SubSection({subSection}: {subSection: Section}) {
           case 'internalAction': // TODO: Add support for internal actions (MVI-2)
             if (!item.type) return null
             if (item.type === 'studio-announcements-modal')
-              return <StudioAnnouncementsMenuItem text={item.title} />
+              return <StudioAnnouncementsMenuItem key={item._key} text={item.title} />
             return (
               item.type === 'show-welcome-modal' && <MenuItem key={item._key} text={item.title} />
             )