fix(portable-text-editor): run empty check directly into decorate fn.

sanity-io · Sep 23, 2022 · 9fcbc5c · 9fcbc5c
1 parent d020ed1
commit 9fcbc5c
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/packages/@sanity/portable-text-editor/src/editor/Editable.tsx b/packages/@sanity/portable-text-editor/src/editor/Editable.tsx
@@ -322,13 +322,8 @@ export const PortableTextEditable = forwardRef(function PortableTextEditable(
     }
   }, [portableTextEditor, scrollSelectionIntoView])
 
-  const isEmpty = useMemo(
-    () => isEqualToEmptyEditor(slateEditor.children, portableTextFeatures),
-    [portableTextFeatures, slateEditor.children]
-  )
-
   const decorate = useCallback(() => {
-    if (isEmpty) {
+    if (isEqualToEmptyEditor(slateEditor.children, portableTextFeatures)) {
       return [
         {
           anchor: {
@@ -344,7 +339,7 @@ export const PortableTextEditable = forwardRef(function PortableTextEditable(
       ]
     }
     return EMPTY_DECORATORS
-  }, [isEmpty])
+  }, [portableTextFeatures, slateEditor.children])
 
   // The editor
   const slateEditable = useMemo(