feat: added components definitions for all intrinsic schema-types

sanity-io · Oct 26, 2022 · ae0d13d · ae0d13d
1 parent ce93ab2
commit ae0d13d
Show file tree

Hide file tree

Showing 6 changed files with 943 additions and 10 deletions.
diff --git a/packages/@sanity/types/src/reference/types.ts b/packages/@sanity/types/src/reference/types.ts
@@ -35,7 +35,8 @@ export type ReferenceFilterResolver = (options: {
 
 /** @public */
 export interface ReferenceFilterResolverOptions {
-  filter: ReferenceFilterResolver
+  filter?: ReferenceFilterResolver
+  filterParams?: never
 }
 
 /** @public */

diff --git a/packages/@sanity/types/src/schema/definition/type/common.ts b/packages/@sanity/types/src/schema/definition/type/common.ts
@@ -28,15 +28,20 @@ export interface BaseSchemaDefinition {
   hidden?: ConditionalProperty
   readOnly?: ConditionalProperty
   icon?: ComponentType | ReactNode
-  components?: {
-    diff?: ComponentType<any> // @todo: use `DiffProps` here
-    field?: ComponentType<any> // @todo: use `FieldProps` here
-    input?: ComponentType<any> // @todo: use `InputProps` here
-    item?: ComponentType<any> // @todo: use `ItemProps` here
-    preview?: ComponentType<any> // @todo: use `PreviewProps` here
-  }
   validation?: unknown
   initialValue?: unknown
+  /*
+   * These are not the properties you are looking for.
+   * To avoid cyclic dependencies on Prop-types, the components property is
+   * added to each intrinsic definition in sanity/core/schema/definitionExtensions.ts
+   */
+  /*components?: {
+    diff?: ComponentType<any>
+    field?: ComponentType<any>
+    input?: ComponentType<any>
+    item?: ComponentType<any>
+    preview?: ComponentType<any>
+  }*/
 }
 
 /** @public */