fix(portable-text-editor): fix potential re-rendering issue

sanity-io · Sep 23, 2022 · f542cd2 · f542cd2
1 parent 96771df
commit f542cd2
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/packages/@sanity/portable-text-editor/src/editor/Editable.tsx b/packages/@sanity/portable-text-editor/src/editor/Editable.tsx
@@ -320,8 +320,13 @@ export const PortableTextEditable = forwardRef(function PortableTextEditable(
     }
   }, [portableTextEditor, scrollSelectionIntoView])
 
+  const isEmpty = useMemo(
+    () => isEqualToEmptyEditor(slateEditor.children, portableTextFeatures),
+    [portableTextFeatures, slateEditor.children]
+  )
+
   const decorate = useCallback(() => {
-    if (isEqualToEmptyEditor(slateEditor.children, portableTextFeatures)) {
+    if (isEmpty) {
       return [
         {
           anchor: {
@@ -337,7 +342,7 @@ export const PortableTextEditable = forwardRef(function PortableTextEditable(
       ]
     }
     return EMPTY_DECORATORS
-  }, [portableTextFeatures, slateEditor.children])
+  }, [isEmpty])
 
   // The editor
   const slateEditable = useMemo(