chore(deps): upgrade oxlint to v.1.16.0, fix `preserve-caught-error` #10685

stipsan · 2025-09-19T15:28:21Z

Description

Renovatebot failed to bump oxlint as it has new rules that need to be fixed/configured.

I've disabled the unicorn/no-array-reverse rule as I don't think we want to use [].toReversed() instead of [].reverse() without properly investigating browser support and such. At least TypeScript didn't like it without changing tsconfig's target so I've disabled the rule for now.
The new preserve-caught-error rule is awesome, it doesn't support --fix yet so I manually fixed the violations ☺️
I've updated renovatebot to PR oxlint and eslint-plugin-oxlint together, as they're intended to be on exactly the same version.

What to review

Does it make sense to forward cause in all the cases? Or should I suppress in some cases?

Testing

CI good then we good!

Notes for release

N/A

vercel · 2025-09-19T15:28:26Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
page-building-studio	Ready	Preview	Comment	Sep 19, 2025 3:31pm
performance-studio	Ready	Preview	Comment	Sep 19, 2025 3:31pm
test-studio	Ready	Preview	Comment	Sep 19, 2025 3:31pm

4 Skipped Deployments

Project	Deployment	Updated (UTC)
e2e-studio	Ignored	Sep 19, 2025 3:31pm
efps	Ignored	Sep 19, 2025 3:31pm
studio-workshop	Ignored	Sep 19, 2025 3:31pm
test-next-studio	Ignored	Sep 19, 2025 3:31pm

github-actions · 2025-09-19T15:28:38Z

⚡️ Editor Performance Report

Updated Fri, 19 Sep 2025 17:34:45 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	20.2 efps (50ms)	20.2 efps (50ms)	+0ms (-/-%)	✅
article (body)	42.1 efps (24ms)	40.7 efps (25ms)	+1ms (+3.4%)	✅
article (string inside object)	22.2 efps (45ms)	20.8 efps (48ms)	+3ms (+6.7%)	✅
article (string inside array)	20.4 efps (49ms)	20.4 efps (49ms)	+0ms (-/-%)	✅
recipe (name)	37.0 efps (27ms)	37.0 efps (27ms)	+0ms (-/-%)	✅
recipe (description)	40.0 efps (25ms)	41.7 efps (24ms)	-1ms (-4.0%)	✅
recipe (instructions)	99.9+ efps (8ms)	99.9+ efps (8ms)	+1ms (-/-%)	✅
singleString (stringField)	47.6 efps (21ms)	45.5 efps (22ms)	+1ms (+4.8%)	✅
synthetic (title)	15.9 efps (63ms)	15.7 efps (64ms)	+1ms (+0.8%)	✅
synthetic (string inside object)	16.9 efps (59ms)	16.9 efps (59ms)	+0ms (-/-%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	50ms	55ms	59ms	117ms	355ms	12.0s
article (body)	24ms	27ms	60ms	101ms	186ms	6.6s
article (string inside object)	45ms	48ms	77ms	150ms	291ms	7.7s
article (string inside array)	49ms	52ms	66ms	158ms	354ms	7.9s
recipe (name)	27ms	30ms	32ms	43ms	0ms	8.2s
recipe (description)	25ms	29ms	33ms	83ms	22ms	5.6s
recipe (instructions)	8ms	10ms	12ms	51ms	0ms	3.2s
singleString (stringField)	21ms	22ms	24ms	27ms	0ms	6.7s
synthetic (title)	63ms	67ms	73ms	221ms	1294ms	15.9s
synthetic (string inside object)	59ms	62ms	64ms	106ms	929ms	8.2s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	50ms	58ms	89ms	157ms	473ms	12.3s
article (body)	25ms	31ms	52ms	114ms	263ms	7.1s
article (string inside object)	48ms	51ms	75ms	141ms	197ms	7.9s
article (string inside array)	49ms	52ms	53ms	67ms	293ms	7.3s
recipe (name)	27ms	30ms	35ms	59ms	18ms	7.9s
recipe (description)	24ms	26ms	31ms	57ms	0ms	5.1s
recipe (instructions)	8ms	10ms	11ms	40ms	0ms	3.2s
singleString (stringField)	22ms	26ms	28ms	31ms	0ms	8.0s
synthetic (title)	64ms	69ms	79ms	384ms	1333ms	15.4s
synthetic (string inside object)	59ms	63ms	68ms	232ms	1020ms	8.5s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

github-actions · 2025-09-19T15:28:38Z

⚡️ Editor Performance Report

Waiting for Editor Performance Tests to finish…

github-actions · 2025-09-19T15:28:42Z

🧪 E2E Preview environment

🔑 Environment Variables for Local Testing

This is the preview URL for the E2E tests: https://e2e-studio-n3kuwd3k6.sanity.dev

To run the E2E tests locally, you can use the following environment variables, then run pnpm test:e2e --ui to open the Playwright test runner.

💬 Remember to build the project first with pnpm build:e2e.

  SANITY_E2E_PROJECT_ID=ittbm412
  SANITY_E2E_BASE_URL=https://e2e-studio-n3kuwd3k6.sanity.dev
  SANITY_E2E_DATASET="update depending the project you want to test (pr-10685-chromium-17862732727 || pr-10685-firefox-17862732727 )"
  SANITY_E2E_DATASET_CHROMIUM=pr-10685-chromium-17862732727
  SANITY_E2E_DATASET_FIREFOX=pr-10685-firefox-17862732727

github-actions · 2025-09-19T15:28:42Z

No changes to documentation

github-actions · 2025-09-19T15:28:43Z

📊 Playwright Test Report

Download Full E2E Report

This report contains test results, including videos of failing tests.

socket-security · 2025-09-19T15:30:51Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	oxlint@1.14.0 ⏵ 1.16.0			⁺²	⁺²
	eslint-plugin-oxlint@1.14.0 ⏵ 1.16.0				⁺²

View full report

bjoerge

This is fantastic, thank you! 💖

juice49

This is great! Thanks!

github-actions · 2025-09-19T15:39:29Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	44.75%	63871 / 142699
🔵	Statements	44.75%	63871 / 142699
🔵	Functions	49.89%	3221 / 6455
🔵	Branches	79.24%	11913 / 15034

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/@sanity/codegen/src/readConfig.ts	0%	0%	0%	0%	1-41
packages/@sanity/util/src/createSafeJsonParser.ts	75%	100%	100%	75%	23-25, 34-35
packages/sanity/src/core/store/_legacy/authStore/createAuthStore.ts	55.02%	45.45%	50%	55.02%	36-37, 47-48, 60, 63-65, 74-76, 82-87, 90-98, 116-147, 181, 185-186, 220, 226-262, 265-274, 277-292
packages/sanity/src/core/studio/copyPaste/__test__/mockClient.ts	76.19%	57.14%	100%	76.19%	39-40, 44-51
packages/sanity/src/presentation/useMainDocument.ts	28.81%	100%	16.66%	28.81%	19-57, 103-188

Generated in workflow #42634 for commit 80bc1f7 by the Vitest Coverage Report Action

stipsan added 2 commits September 19, 2025 16:27

chore(deps): update dependency oxlint to v1.16.0

b3b5458

chore: fix preserve-caught-error violations

80bc1f7

stipsan requested review from a team as code owners September 19, 2025 15:28

stipsan requested review from juice49 and removed request for a team September 19, 2025 15:28

vercel bot deployed to Preview – page-building-studio September 19, 2025 15:30 View deployment

vercel bot deployed to Preview – performance-studio September 19, 2025 15:30 View deployment

stipsan enabled auto-merge (squash) September 19, 2025 15:30

vercel bot deployed to Preview – test-studio September 19, 2025 15:31 View deployment

bjoerge approved these changes Sep 19, 2025

View reviewed changes

juice49 approved these changes Sep 19, 2025

View reviewed changes

stipsan merged commit 84d4a28 into main Sep 19, 2025
69 of 73 checks passed

stipsan deleted the bump-oxlint branch September 19, 2025 17:13

squiggler bot mentioned this pull request Sep 19, 2025

chore(release): publish v4.10.0 #10656

Merged

chore(deps): upgrade oxlint to v.1.16.0, fix preserve-caught-error #10685

chore(deps): upgrade oxlint to v.1.16.0, fix preserve-caught-error #10685

Uh oh!

Conversation

stipsan commented Sep 19, 2025

Description

What to review

Testing

Notes for release

Uh oh!

vercel bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

Uh oh!

github-actions bot commented Sep 19, 2025

⚡️ Editor Performance Report

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 E2E Preview environment

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Playwright Test Report

Uh oh!

socket-security bot commented Sep 19, 2025

Uh oh!

bjoerge left a comment

Choose a reason for hiding this comment

Uh oh!

juice49 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 19, 2025

Coverage Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chore(deps): upgrade oxlint to v.1.16.0, fix `preserve-caught-error` #10685

chore(deps): upgrade oxlint to v.1.16.0, fix `preserve-caught-error` #10685

vercel bot commented Sep 19, 2025 •

edited

Loading

github-actions bot commented Sep 19, 2025 •

edited

Loading

github-actions bot commented Sep 19, 2025 •

edited

Loading

github-actions bot commented Sep 19, 2025 •

edited

Loading

github-actions bot commented Sep 19, 2025 •

edited

Loading