Add temporary part to inject components below the editor #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
bjoerge
pushed a commit
that referenced
this pull request
Aug 30, 2017
* [desk-tool] Fix lint errors * [desk-tool] Add temporary part to inject components below the editor
Merged
bjoerge
pushed a commit
that referenced
this pull request
Sep 1, 2017
* [desk-tool] Fix lint errors * [desk-tool] Add temporary part to inject components below the editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a part that can be used to inject components below the editor in the desk tool.
We don't want to encourage using the main editor pane for functionality such as this, and as such I've marked the part as deprecated already. It will be removed once we get a meta pane or similar.
Also fixes a few lint errors that were present in the editor component.