Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[form-builder] Remove createFormBuilderFactory #151

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Aug 31, 2017

This removes the rather unnecessary createFormBuilder factory function which has been causing a few circular import issues. Should be pretty safe to remove since it has never been exposed in the sanity api, but added an error if someone still tries to call it just in case.

@bjoerge bjoerge requested a review from rexxars August 31, 2017 13:10
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good simplification of the API to me - can't really vouch for the internals without digging quite deep, but looks good on the surface!

@bjoerge bjoerge merged commit 4386525 into next Aug 31, 2017
@bjoerge bjoerge deleted the refactor/remove-form-builder-factory branch August 31, 2017 13:20
@bjoerge bjoerge mentioned this pull request Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants