refactor(form-builder): simplify cross dataset reference config (#3670) #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sjelfull
changed the base branch from
chore/sc-21163/cherry-pick-changes-for-v3-on-next
to
v3
sjelfull
force-pushed
the
chore/sc-21163/cherry-pick-cdr-updates-for-v3-on-next
branch
from
58a245b to
d456e73
Compare
sjelfull
force-pushed
the
chore/sc-21163/cherry-pick-cdr-updates-for-v3-on-next
branch
2 times, most recently
from
795cfb2 to
8c7bbda
Compare
sjelfull
force-pushed
the
chore/sc-21163/cherry-pick-cdr-updates-for-v3-on-next
branch
from
8c7bbda to
b3cd5ec
Compare
sjelfull
force-pushed
the
chore/sc-21163/cherry-pick-cdr-updates-for-v3-on-next
branch
from
b3cd5ec to
d6fa073
Compare
sjelfull
force-pushed
the
chore/sc-21163/cherry-pick-cdr-updates-for-v3-on-next
branch
from
99f8c5d to
65edd1d
Compare
bjoerge
approved these changes
Nov 1, 2022
* refactor(form-builder): remove token and project id support in cross dataset references * refactor(base): remove token header from preview requests * refactor(schema): remove project and token validation from cross dataset reference schema * refactor(schema): derive search fields from preview definition for cross dataset references * refactor(desk-tool): remove cross dataset reference tokens from confirm delete dialog requests * chore(test-studio): update cross dataset reference schema in test studio * test(form-builder): remove project and experimental search from cross dataset reference test * refactor(types): remove token and project id support in cross dataset references * fix(desk-tool): replace projects terminology in confirm delete dialog [sc-25932] * fix(form-builder): remove extra whitespace on reference inputs when empty [sc-25936] * fix(form-builder): fix inconsistent padding on CDR preview [sc-25927] * fix(desk-tool): handle unavailable dataset names in delete dialog [sc-25932] * fix(form-builder): update inconsistent copy for missing document [sc-25929] * fix(form-builder): handle invalid image sources in preview * fix(form-builder): limit CDR warning tooltip width * fix(form-builder): fix focus handling when editing array reference * feat(form-builder): show warning if cdr feature is disabled * fix(form-builder): removed cached inital state * refactor(form-builder): remove unnecessary conditional Co-authored-by: Espen Hovlandsdal <espen@hovlandsdal.com> Signed-off-by: Fred Carlsen <fred@sjelfull.no>
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
* refactor(form-builder): remove token and project id support in cross dataset references * refactor(base): remove token header from preview requests * refactor(schema): remove project and token validation from cross dataset reference schema * refactor(schema): derive search fields from preview definition for cross dataset references * refactor(desk-tool): remove cross dataset reference tokens from confirm delete dialog requests * chore(test-studio): update cross dataset reference schema in test studio * test(form-builder): remove project and experimental search from cross dataset reference test * refactor(types): remove token and project id support in cross dataset references * fix(desk-tool): replace projects terminology in confirm delete dialog [sc-25932] * fix(form-builder): remove extra whitespace on reference inputs when empty [sc-25936] * fix(form-builder): fix inconsistent padding on CDR preview [sc-25927] * fix(desk-tool): handle unavailable dataset names in delete dialog [sc-25932] * fix(form-builder): update inconsistent copy for missing document [sc-25929] * fix(form-builder): handle invalid image sources in preview * fix(form-builder): limit CDR warning tooltip width * fix(form-builder): fix focus handling when editing array reference * feat(form-builder): show warning if cdr feature is disabled * fix(form-builder): removed cached inital state * refactor(form-builder): remove unnecessary conditional Co-authored-by: Espen Hovlandsdal <espen@hovlandsdal.com> Signed-off-by: Fred Carlsen <fred@sjelfull.no>
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
sjelfull
force-pushed
the
chore/sc-21163/cherry-pick-cdr-updates-for-v3-on-next
branch
from
65edd1d to
7748411
Compare
sjelfull
deleted the
chore/sc-21163/cherry-pick-cdr-updates-for-v3-on-next
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #3670 to v3
refactor(form-builder): remove token and project id support in cross dataset references
refactor(base): remove token header from preview requests
refactor(schema): remove project and token validation from cross dataset reference schema
refactor(schema): derive search fields from preview definition for cross dataset references
refactor(desk-tool): remove cross dataset reference tokens from confirm delete dialog requests
chore(test-studio): update cross dataset reference schema in test studio
test(form-builder): remove project and experimental search from cross dataset reference test
refactor(types): remove token and project id support in cross dataset references
fix(desk-tool): replace projects terminology in confirm delete dialog
[sc-25932]
[sc-25936]
[sc-25927]
[sc-25932]
[sc-25929]
fix(form-builder): handle invalid image sources in preview
fix(form-builder): limit CDR warning tooltip width
fix(form-builder): fix focus handling when editing array reference
feat(form-builder): show warning if cdr feature is disabled
fix(form-builder): removed cached inital state
refactor(form-builder): remove unnecessary conditional
What to review
Notes for release