Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[form-builder] Set project ID for tests, allow local module resolution #383

Merged
merged 1 commit into from
Nov 26, 2017

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Nov 26, 2017

The tests were not passing due to some issues in the resolver. This has been fixed in #381.
Once that was fixed, there were a few more issues; project ID not being defined, as well as a few modules that needs to be resolved in a different way due to being development dependencies.

There are still issues with the tests, but they seem to be form-builder related now, at least.

@rexxars rexxars requested a review from bjoerge November 26, 2017 01:59
@rexxars rexxars changed the base branch from master to next November 26, 2017 01:59
@rexxars rexxars merged commit 31c6ada into next Nov 26, 2017
@rexxars rexxars deleted the form-builder-tests branch November 26, 2017 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants