[form-builder] Memoize hot methods #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
force-pushed
the
memoize-type-to-input-map
branch
from
4b76963
to
3bb7309
Compare
rexxars
approved these changes
Nov 29, 2017
Based on my rather unscientific tests: Not really a lot. I think it would make the biggest difference on large forms with many input fields, or if a custom input resolver does more heavy work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolution of which input to use for which schema type is currently treated as a static mapping between schema type => input component. The resolution is done quite excessively, so this PR memoizes the schema type => input component map.
We may consider supporting dynamic input resolution later on, but I have not seen any compelling reasons to do so yet.