[components] Cleanup fieldset - support isExpanded by default #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
force-pushed
the
cleanup-fieldset
branch
from
cfc7d89
to
fd88c5a
Compare
bjoerge
force-pushed
the
cleanup-fieldset
branch
from
fd88c5a
to
f510399
Compare
kristofferjs
approved these changes
Nov 30, 2017
|
Tested and approved |
rexxars
pushed a commit
that referenced
this pull request
Dec 1, 2017
rexxars
pushed a commit
that referenced
this pull request
Dec 6, 2017
skogsmaskin
pushed a commit
that referenced
this pull request
Dec 7, 2017
rexxars
pushed a commit
that referenced
this pull request
Dec 7, 2017
rexxars
pushed a commit
that referenced
this pull request
Dec 20, 2017
bjoerge
added a commit
that referenced
this pull request
Jan 9, 2018
bjoerge
added a commit
that referenced
this pull request
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to deep link to form builder fields, the default fieldset must support being expanded initially. This PR fixes that.
Summary:
isCollapsible-prop that must be true to make the fieldset collapsible.isCollapsed-prop that, renders the fieldset as collapsed initially.