build: remove Version step from release workflow
#7032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Jun 26, 2024 11:23 PM (UTC)
|
the `version` step was added so that the build could be ran with updated package.json version but this was cause an issue when installing after the version bump. it's not strictly necessary so we'll be removing this as a result
ricokahler
force-pushed
the
fix/remove-version-step-from-release
branch
from
820e2d3
to
bf652c7
Compare
rexxars
approved these changes
Jun 26, 2024
ricokahler
added a commit
that referenced
this pull request
Jun 27, 2024
* build: remove `Version` step from release workflow the `version` step was added so that the build could be ran with updated package.json version but this was cause an issue when installing after the version bump. it's not strictly necessary so we'll be removing this as a result * fix: define PKG_VERSION from workflow input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Versionstep in the release.yml workflow was added so that the build could be ran with updatedpackage.jsonversion but this was causing an issue with mismatched types and packages causing the build when installing after the version bump. it's not strictly necessary so we'll be removing this as a result.What to review
Do we rely on theVersionstep at all? I believe we have measures in place that get the monorepo version in other ways so this version step should not be necessary.Had a sync with @rexxars and we found that if the environment variable
PKG_VERSIONis set, it circumvents the needs to runlerna versionprior to running the build.Testing
In order to test the above theory, I ran the build locally with the environment variable PKG_VERSION set to a different version than in the package.json and looked at the build result. All places where the version was referenced reflected the
PKG_VERSIONinstead.Notes for release
N/A - internal build fix