Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): Update presence menu button for inviting new collaborators #7406

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

drewlyton
Copy link
Contributor

@drewlyton drewlyton commented Aug 21, 2024

Description

This PR makes some updates to the presence dropdown menu action button to encourage seat expansion.

SCR-20240826-oisj

  • Button text has been changed to "Invite collaborators"
  • @sanity/icons has been updated to version 3.4.0
  • Icon has been changed to new AddUserIcon
  • Link has been updated to take the user directly to the project members tab

Linear issues

What to review

Review the text and link changes.

Testing

Change does not affect or require new automated tests. To test the change, navigate to a studio document with someone else present and open the presence menu by clicking on the user avatars.

Notes for release

No notes for release

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 6:13pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 6:13pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 6:13pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 6:13pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 6:13pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 6:13pm

@drewlyton drewlyton changed the title feat: Update precense menu button for inviting new collaborators feat(sanity): Update precense menu button for inviting new collaborators Aug 21, 2024
Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Aug 21, 2024

Component Testing Report Updated Aug 27, 2024 6:16 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 38s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 13s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 23s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@drewlyton drewlyton force-pushed the feat/update-manage-member-button-gro-2406 branch from ebb2ac9 to fae3851 Compare August 22, 2024 12:37
@drewlyton drewlyton marked this pull request as ready for review August 22, 2024 12:37
@drewlyton drewlyton requested a review from a team August 22, 2024 12:37
@drewlyton drewlyton requested a review from a team as a code owner August 22, 2024 12:37
@drewlyton drewlyton requested review from jordanl17, juice49 and svirs and removed request for a team August 22, 2024 12:37
@drewlyton drewlyton marked this pull request as draft August 22, 2024 12:54
@svirs svirs changed the title feat(sanity): Update precense menu button for inviting new collaborators feat(sanity): Update presence menu button for inviting new collaborators Aug 23, 2024
@drewlyton drewlyton force-pushed the feat/update-manage-member-button-gro-2406 branch from c7dbfb7 to 63621f8 Compare August 26, 2024 19:56
@drewlyton drewlyton marked this pull request as ready for review August 26, 2024 19:56
ricokahler
ricokahler previously approved these changes Aug 26, 2024
drewlyton and others added 2 commits August 26, 2024 16:17
@ricokahler ricokahler dismissed joneidejohnsen’s stale review August 27, 2024 18:02

confirmed with drew that this PR is ready

@ricokahler ricokahler added this pull request to the merge queue Aug 27, 2024
Merged via the queue into next with commit 064519a Aug 27, 2024
25 of 34 checks passed
@ricokahler ricokahler deleted the feat/update-manage-member-button-gro-2406 branch August 27, 2024 18:04
jordanl17 pushed a commit that referenced this pull request Aug 29, 2024
…ors (#7406)

* feat: Update precense menu button for inviting new collaborators

* feat: use query param to automatically open invite modal

* feat: update sanity icons

* Update packages/sanity/src/core/i18n/bundles/studio.ts

Co-authored-by: Jon Eide Johnsen <joneidejohnsen@gmail.com>

* feat: update icon placement and i18n strings

* Update packages/sanity/src/core/studio/components/navbar/navDrawer/ManageMenu.tsx

Co-authored-by: Jon Eide Johnsen <joneidejohnsen@gmail.com>

* fix: add query param to invite link

---------

Co-authored-by: Jon Eide Johnsen <joneidejohnsen@gmail.com>
Co-authored-by: Rico Kahler <ricokahler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants