-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sanity): Update presence menu button for inviting new collaborators #7406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
drewlyton
changed the title
feat: Update precense menu button for inviting new collaborators
feat(sanity): Update precense menu button for inviting new collaborators
Aug 21, 2024
No changes to documentation |
Component Testing Report Updated Aug 27, 2024 6:16 PM (UTC) ❌ Failed Tests (1) -- expand for details
|
drewlyton
force-pushed
the
feat/update-manage-member-button-gro-2406
branch
from
August 22, 2024 12:37
ebb2ac9
to
fae3851
Compare
drewlyton
requested review from
jordanl17,
juice49 and
svirs
and removed request for
a team
August 22, 2024 12:37
svirs
changed the title
feat(sanity): Update precense menu button for inviting new collaborators
feat(sanity): Update presence menu button for inviting new collaborators
Aug 23, 2024
drewlyton
force-pushed
the
feat/update-manage-member-button-gro-2406
branch
from
August 26, 2024 19:56
c7dbfb7
to
63621f8
Compare
ricokahler
previously approved these changes
Aug 26, 2024
packages/sanity/src/core/studio/components/navbar/navDrawer/ManageMenu.tsx
Outdated
Show resolved
Hide resolved
…nageMenu.tsx Co-authored-by: Jon Eide Johnsen <joneidejohnsen@gmail.com>
ricokahler
approved these changes
Aug 27, 2024
ricokahler
dismissed
joneidejohnsen’s stale review
August 27, 2024 18:02
confirmed with drew that this PR is ready
jordanl17
pushed a commit
that referenced
this pull request
Aug 29, 2024
…ors (#7406) * feat: Update precense menu button for inviting new collaborators * feat: use query param to automatically open invite modal * feat: update sanity icons * Update packages/sanity/src/core/i18n/bundles/studio.ts Co-authored-by: Jon Eide Johnsen <joneidejohnsen@gmail.com> * feat: update icon placement and i18n strings * Update packages/sanity/src/core/studio/components/navbar/navDrawer/ManageMenu.tsx Co-authored-by: Jon Eide Johnsen <joneidejohnsen@gmail.com> * fix: add query param to invite link --------- Co-authored-by: Jon Eide Johnsen <joneidejohnsen@gmail.com> Co-authored-by: Rico Kahler <ricokahler@gmail.com>
This was referenced Sep 20, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes some updates to the presence dropdown menu action button to encourage seat expansion.
@sanity/icons
has been updated to version 3.4.0Linear issues
What to review
Review the text and link changes.
Testing
Change does not affect or require new automated tests. To test the change, navigate to a studio document with someone else present and open the presence menu by clicking on the user avatars.
Notes for release
No notes for release