feat(sanity): add always present document action to copy url to clipboard #7416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Aug 26, 2024 6:55 PM (UTC) ✅ All Tests Passed -- expand for details
|
drewlyton
force-pushed
the
feat/copy-document-link-gro-2405
branch
from
04cbf84
to
24e3fc2
Compare
bjoerge
previously approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Code looks good from my side.
I'll defer to @runeb about UI location, etc. Just a note: this is copying a link to the document within the navigation structure that the user took to get to it, and might not always be what the user expect. As an alternative to consider (if you didn't already), you could copy the intent link for editing the document (this is what you navigate to when clicking the presence menu, for reference)
@drewlyton Support this, and suggest we use the intent link here rather than the actual URL |
ricokahler
previously approved these changes
Aug 26, 2024
ricokahler
approved these changes
Aug 26, 2024
jordanl17
pushed a commit
that referenced
this pull request
Aug 29, 2024
…oard (#7416) * feat: add always present document action to copy url to clipboard * chore: add comment to menuitems * feat: add check for navigator presence * feat: add tracking for copy document URL * fix: update to use intent URL instead of just current URL * feat: resolve intent link on demand * revert: go back to just copying current URL * chore: add comment explanation
jordanl17
added a commit
that referenced
this pull request
Aug 29, 2024
…oard (#7416) * feat: add always present document action to copy url to clipboard * chore: add comment to menuitems * feat: add check for navigator presence * feat: add tracking for copy document URL * fix: update to use intent URL instead of just current URL * feat: resolve intent link on demand * revert: go back to just copying current URL * chore: add comment explanation
This was referenced Sep 20, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a document pane menu item that enables user's to easily copy the current
document's URL to their clipboard and share it with colleagues and collaborators.
Linear issue
Screen.Recording.2024-08-23.at.12.11.58.PM.mov
What to review
The code add for this feature is relatively straightforward. However, I'm unsure if the logic's location and the placement of the internalization strings is acceptable. Feedback on this would be greatly appreciated.
Testing
To test, navigate to a document and click on the added menu item. The current URL should be successfully copied to the clipboard.