Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update how bundleSlug is obtained from the version ids #7426

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

When the new versions id was introduced versions.release-slug.foo the update to the way we calculate the bundleSlug was not added.
This adds that change, using the new getVersionFromId function which gives us safety in how the bundleSlug is obtained from the id.

Previously, version ids were release-slug.foo that's why we were accessing it using the .at(0)

What to review

Testing

Notes for release

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 8:47am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 8:47am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 8:47am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 8:47am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 8:47am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Aug 28, 2024 8:47am

@pedrobonamin pedrobonamin marked this pull request as ready for review August 28, 2024 08:41
@pedrobonamin pedrobonamin requested a review from a team as a code owner August 28, 2024 08:41
@pedrobonamin pedrobonamin requested review from cngonzalez and removed request for a team August 28, 2024 08:41
Copy link
Contributor

No changes to documentation

Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

Copy link
Contributor

Component Testing Report Updated Aug 28, 2024 8:55 AM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 36s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 51s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 17s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 26s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@pedrobonamin pedrobonamin merged commit ff76dea into corel Aug 28, 2024
42 checks passed
@pedrobonamin pedrobonamin deleted the fix-corel-incorrect-bundle-slug branch August 28, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants