-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): update how bundleSlug is obtained from the version ids #7426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
pedrobonamin
requested review from
juice49 and
RitaDias
and removed request for
cngonzalez
August 28, 2024 08:42
RitaDias
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀
Component Testing Report Updated Aug 28, 2024 8:55 AM (UTC) ❌ Failed Tests (1) -- expand for details
|
juice49
pushed a commit
that referenced
this pull request
Sep 3, 2024
RitaDias
pushed a commit
that referenced
this pull request
Oct 3, 2024
juice49
pushed a commit
that referenced
this pull request
Oct 4, 2024
juice49
pushed a commit
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the new versions id was introduced
versions.release-slug.foo
the update to the way we calculate thebundleSlug
was not added.This adds that change, using the new
getVersionFromId
function which gives us safety in how the bundleSlug is obtained from the id.Previously, version ids were
release-slug.foo
that's why we were accessing it using the.at(0)
What to review
Testing
Notes for release