-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improved data testing by ui and test id #7428
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Aug 29, 2024 10:30 AM (UTC) ❌ Failed Tests (1) -- expand for details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LET'S GO JORDAN 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thanks
Description
Improves the options to find elements when testing dialogs; adds support to test by
data-ui
attrWhat to review
data-testid
s for the CTAs in dialogbyDataUi
- which can be used asqueryByDataUi
/getAllByDataUi
etc - allows for finding elements by their pre-existingdata-ui
attributes, rather than always having to add ondata-testid
sTesting
Neither of these are currently used in tests, however when content releases is merged they are employed there.
Additionally, this will help with testing across studio in some cases currently
Notes for release
N/A