fix(core): version document's history was returning error #7438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Aug 30, 2024 2:54 PM (UTC) ✅ All Tests Passed -- expand for details
|
jordanl17
changed the title
RitaDias
reviewed
Aug 30, 2024
|
Also, not sure what but @jordanl17 seems that the |
bjoerge
reviewed
Aug 30, 2024
| @@ -147,7 +149,7 @@ export class Timeline { | |||
| id: event.id, | |||
| author: event.author, | |||
| timestamp: event.timestamp, | |||
| draftEffect: event.effects[this.draftId], | |||
| draftEffect: event.effects[this.versionId], | |||
There was a problem hiding this comment.
did you consider renaming draftEffect to versionEffect?
There was a problem hiding this comment.
I briefly did, but worried it would have too big a footprint. However just looked at it again and draftEffect's use is quite limited, so I've made this improvement. Thanks
…ic use with versions
jordanl17
force-pushed
the
corel-115-version-docs-history-error
branch
from
3eb6403
to
a5fcbb1
Compare
juice49
approved these changes
Aug 30, 2024
juice49
pushed a commit
that referenced
this pull request
Sep 3, 2024
* fix: draftId correct set in timeline for version docs * refactor: timeline uses documentId rather than publishedId for agnostic use with versions * refactor(core): defining versionId rather than draftId * refactor(core): refactor to better reflect use of version nomenclature in history * fix(core): resolving tsdoc issue with destructure * fix(core): resolving tsdoc issue with destructure
RitaDias
pushed a commit
that referenced
this pull request
Oct 3, 2024
* fix: draftId correct set in timeline for version docs * refactor: timeline uses documentId rather than publishedId for agnostic use with versions * refactor(core): defining versionId rather than draftId * refactor(core): refactor to better reflect use of version nomenclature in history * fix(core): resolving tsdoc issue with destructure * fix(core): resolving tsdoc issue with destructure
juice49
pushed a commit
that referenced
this pull request
Oct 4, 2024
* fix: draftId correct set in timeline for version docs * refactor: timeline uses documentId rather than publishedId for agnostic use with versions * refactor(core): defining versionId rather than draftId * refactor(core): refactor to better reflect use of version nomenclature in history * fix(core): resolving tsdoc issue with destructure * fix(core): resolving tsdoc issue with destructure
juice49
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix: draftId correct set in timeline for version docs * refactor: timeline uses documentId rather than publishedId for agnostic use with versions * refactor(core): defining versionId rather than draftId * refactor(core): refactor to better reflect use of version nomenclature in history * fix(core): resolving tsdoc issue with destructure * fix(core): resolving tsdoc issue with destructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://www.loom.com/share/b1e04c690f7b45dcb40d153cf055c97b?sid=6a600c40-cf41-4bc3-ad0c-d0b90bba4414
What to review
publishedIdtodocumentId, is to give affordance that in cases where the document is a version, then publishedId is a misnomer. It was really this line:this.draftId = isVersionId(documentId) ? documentId :drafts.${documentId}`` where it felt incorrect to refer topublishedIdTimelineto useversionIdto reference a version Id and a canonical draftTesting
N/A
Notes for release
N/A