fix(core): update intent link for releases tool #7468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
pedrobonamin
commented
Sep 4, 2024
| return Boolean(intent === 'release' && params.slug) | ||
| canHandleIntent: (intent) => { | ||
| // If intent is release, open the releases tool. | ||
| return Boolean(intent === 'release') |
There was a problem hiding this comment.
Instead of not resolving the intent if the params are missing, resolve to the tool at root level.
pedrobonamin
force-pushed
the
corel-157
branch
from
e877986
to
b99fbdc
Compare
|
Component Testing Report Updated Sep 5, 2024 6:55 AM (UTC) ✅ All Tests Passed -- expand for details
|
pedrobonamin
force-pushed
the
corel-157
branch
from
fcccaa2
to
dc3400c
Compare
pedrobonamin
requested review from
binoy14,
a team and
juice49
and removed request for
a team and
binoy14
pedrobonamin
commented
Sep 5, 2024
| expect(screen.queryByTestId('button-document-release')).toBeNull() | ||
| }) | ||
|
|
||
| it('should navigate to the release intent when the bundle badge is clicked', async () => { |
There was a problem hiding this comment.
This test doesn't apply anymore, because we are not rendering a button, we are now rendering a <a>
That's also the reason why instead of using a getByTestId getter for the button we are now using a getByRole("link") getter in this tests
RitaDias
pushed a commit
that referenced
this pull request
Oct 3, 2024
* fix(core): update intent link for releases tool * chore(core): rename releases tool bundleId param to releaseId * chore(core): update DocumentPerspectiveMenu test
juice49
pushed a commit
that referenced
this pull request
Oct 4, 2024
* fix(core): update intent link for releases tool * chore(core): rename releases tool bundleId param to releaseId * chore(core): update DocumentPerspectiveMenu test
juice49
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix(core): update intent link for releases tool * chore(core): rename releases tool bundleId param to releaseId * chore(core): update DocumentPerspectiveMenu test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with intent link in which the intent was not resolved correctly.
It also replaces the for a component, which will allow users to cmd + click to open in new tab.
Updates the
bundleIdparam in the releases tool router forreleaseIdWhat to review
Are the changes correct?
Testing
Existing tests have been updated to reflect the change.
Notes for release
n/a