-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move cliInitializedAt call higher in init flow #7558
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Oct 1, 2024 3:11 PM (UTC) ✅ All Tests Passed -- expand for details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do these in parallel? (Promise.all()
?) Would be good to not block if the server call takes a while.
Used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The call to patch the
cliInitializedAt
needs to be moved above the bootstrapping of the template as it is is necessary for indicating failure cases from that function.Testing
Should not break anything in project init flow. (all errors from the call will continue to be caught and debug logged only)
Notes for release
not required