You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add release types to bundles metadata (asap, scheduled or undecided)
Names are still in flux, these seemed to be the ones that we would least regret in the long run as well as make it clearer from a code standpoint, I'm open to other suggestions though!
Also, we were planning on having these properties exist in a separate place other than the bundle metadata, but due to limitations outside of our control this is the temporary solution
What to review
Does the code provided make sense?
Keep in mind, this is simply for unblocking us in continuing corel development, the actual development and changes to the modal will be done in a separate task and so are out of scope
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
55ms
61ms
74ms
217ms
453ms
13.1s
article (body)
17ms
19ms
26ms
178ms
273ms
5.6s
article (string inside object)
51ms
53ms
60ms
149ms
134ms
8.1s
article (string inside array)
65ms
67ms
74ms
215ms
775ms
9.4s
recipe (name)
31ms
33ms
36ms
84ms
0ms
8.5s
recipe (description)
28ms
30ms
33ms
143ms
0ms
6.0s
recipe (instructions)
7ms
8ms
8ms
10ms
0ms
3.2s
synthetic (title)
65ms
71ms
80ms
466ms
1525ms
15.3s
synthetic (string inside object)
63ms
65ms
72ms
543ms
1404ms
9.6s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
72ms
79ms
96ms
304ms
2037ms
15.5s
article (body)
16ms
19ms
21ms
261ms
382ms
5.6s
article (string inside object)
67ms
71ms
75ms
169ms
1840ms
9.9s
article (string inside array)
83ms
86ms
95ms
256ms
2611ms
11.3s
recipe (name)
46ms
48ms
53ms
107ms
663ms
10.2s
recipe (description)
44ms
47ms
51ms
165ms
490ms
7.7s
recipe (instructions)
6ms
8ms
9ms
23ms
0ms
3.2s
synthetic (title)
163ms
176ms
201ms
361ms
9529ms
25.6s
synthetic (string inside object)
155ms
161ms
170ms
1125ms
8698ms
19.9s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add release types to bundles metadata (asap, scheduled or undecided)
Names are still in flux, these seemed to be the ones that we would least regret in the long run as well as make it clearer from a code standpoint, I'm open to other suggestions though!
Also, we were planning on having these properties exist in a separate place other than the bundle metadata, but due to limitations outside of our control this is the temporary solution
What to review
Does the code provided make sense?
Keep in mind, this is simply for unblocking us in continuing corel development, the actual development and changes to the modal will be done in a separate task and so are out of scope
Testing
Updated tests to pass