fix(core): boolean value in search shows actual value #7623

binoy14 · 2024-10-15T20:09:19Z

Description

Fixes issue where boolean values were not showing the proper value in search. See issue #7608

What to review

Changes makes sense

Testing

I have added unit tests for the boolean case and basic tests covering the FilterLabel component's responsibilities

Notes for release

Fixes an issue where boolean filters in search did not show the actual value

vercel · 2024-10-15T20:09:23Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 10:19pm
performance-studio	✅ Ready (Inspect)	Visit Preview		Oct 15, 2024 10:19pm
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 10:19pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 10:19pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 10:19pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Oct 15, 2024 10:19pm

binoy14 · 2024-10-15T20:09:37Z

fix(core): boolean value in search shows actual value #7623 👈
next

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @binoy14 and the rest of your teammates on Graphite

binoy14 · 2024-10-15T20:12:23Z

packages/sanity/test/testUtils/TestProvider.tsx

  WorkspaceProvider,
 } from '../../src/core'
 import {studioDefaultLocaleResources} from '../../src/core/i18n/bundles/studio'
+import {LocaleProviderBase} from '../../src/core/i18n/components/LocaleProvider'


For some reason the test was failing without this change. I think this probably has to do with some circular dependency somewhere and it's better to avoid barrel imports

github-actions · 2024-10-15T20:12:38Z

No changes to documentation

binoy14 · 2024-10-15T20:13:02Z

package.json

@@ -88,6 +88,7 @@
    "test": "run-s test:vitest test:jest",
    "test:jest": "jest --forceExit",
    "test:vitest": "vitest --run",
+    "test:vitest:watch": "vitest --watch",


Added a watch command, let me know if y'all are not a fan

github-actions · 2024-10-15T20:18:28Z

Component Testing Report Updated Oct 15, 2024 10:17 PM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	45s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	8s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	31s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	38s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	18s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	11s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	3m 0s	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	45s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 42s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 17s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	8s	3	9
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	27s	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	18s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	36s	12	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-10-15T20:20:24Z

⚡️ Editor Performance Report

Updated Tue, 15 Oct 2024 22:19:38 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	18.2 efps (55ms)	18.3 efps (55ms)	-1ms (-0.9%)	✅
article (body)	58.0 efps (17ms)	67.3 efps (15ms)	-2ms (-13.9%)	✅
article (string inside object)	19.6 efps (51ms)	20.0 efps (50ms)	-1ms (-2.0%)	✅
article (string inside array)	15.0 efps (67ms)	15.2 efps (66ms)	-1ms (-0.8%)	✅
recipe (name)	25.6 efps (39ms)	26.3 efps (38ms)	-1ms (-2.6%)	✅
recipe (description)	27.8 efps (36ms)	29.4 efps (34ms)	-2ms (-5.6%)	✅
recipe (instructions)	99.9+ efps (9ms)	99.9+ efps (10ms)	+1ms (-/-%)	✅
synthetic (title)	13.5 efps (74ms)	13.7 efps (73ms)	-1ms (-1.4%)	✅
synthetic (string inside object)	14.8 efps (68ms)	13.7 efps (73ms)	+6ms (+8.1%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	55ms	60ms	71ms	193ms	345ms	12.9s
article (body)	17ms	19ms	31ms	124ms	265ms	5.7s
article (string inside object)	51ms	55ms	73ms	231ms	295ms	8.3s
article (string inside array)	67ms	71ms	85ms	236ms	872ms	9.3s
recipe (name)	39ms	43ms	59ms	92ms	26ms	9.9s
recipe (description)	36ms	39ms	60ms	134ms	6ms	6.9s
recipe (instructions)	9ms	10ms	11ms	24ms	0ms	3.6s
synthetic (title)	74ms	79ms	96ms	398ms	1695ms	15.8s
synthetic (string inside object)	68ms	70ms	77ms	587ms	1685ms	10.0s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	55ms	58ms	82ms	182ms	292ms	13.4s
article (body)	15ms	17ms	21ms	51ms	93ms	4.9s
article (string inside object)	50ms	54ms	75ms	185ms	164ms	8.1s
article (string inside array)	66ms	70ms	118ms	247ms	811ms	9.5s
recipe (name)	38ms	41ms	70ms	91ms	0ms	9.6s
recipe (description)	34ms	38ms	62ms	106ms	23ms	6.6s
recipe (instructions)	10ms	11ms	12ms	26ms	0ms	3.7s
synthetic (title)	73ms	79ms	96ms	180ms	1570ms	15.8s
synthetic (string inside object)	73ms	78ms	147ms	448ms	1789ms	10.7s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

packages/sanity/src/core/studio/components/navbar/search/components/common/FilterLabel.tsx

* next: fix(core): boolean value in search shows actual value (#7623) v3.61.0

fix(core): boolean value in search shows actual value

57ba0ba

binoy14 commented Oct 15, 2024

View reviewed changes

vercel bot deployed to Preview – performance-studio October 15, 2024 20:12 View deployment

binoy14 commented Oct 15, 2024

View reviewed changes

vercel bot deployed to Preview – page-building-studio October 15, 2024 20:13 View deployment

vercel bot deployed to Preview – test-studio October 15, 2024 20:13 View deployment

vercel bot deployed to Preview – test-next-studio October 15, 2024 20:17 View deployment

vercel bot deployed to Preview – test-compiled-studio October 15, 2024 20:20 View deployment

binoy14 marked this pull request as ready for review October 15, 2024 20:22

binoy14 requested a review from a team as a code owner October 15, 2024 20:22

binoy14 requested review from ryanbonial and removed request for a team October 15, 2024 20:22

ryanbonial reviewed Oct 15, 2024

View reviewed changes

packages/sanity/src/core/studio/components/navbar/search/components/common/FilterLabel.tsx Outdated Show resolved Hide resolved

fix(core): use translation strings for boolean values

4020788

vercel bot deployed to Preview – performance-studio October 15, 2024 22:12 View deployment

vercel bot deployed to Preview – page-building-studio October 15, 2024 22:12 View deployment

vercel bot deployed to Preview – test-studio October 15, 2024 22:13 View deployment

vercel bot deployed to Preview – test-next-studio October 15, 2024 22:17 View deployment

vercel bot deployed to Preview – test-compiled-studio October 15, 2024 22:19 View deployment

rexxars approved these changes Oct 15, 2024

View reviewed changes

ryanbonial approved these changes Oct 15, 2024

View reviewed changes

binoy14 added this pull request to the merge queue Oct 16, 2024

Merged via the queue into next with commit 4ffa079 Oct 16, 2024
67 checks passed

binoy14 deleted the sdk-9 branch October 16, 2024 01:49

bjoerge added a commit that referenced this pull request Oct 16, 2024

chore: merge 'next' into corel

98775b4

* next: fix(core): boolean value in search shows actual value (#7623) v3.61.0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): boolean value in search shows actual value #7623

fix(core): boolean value in search shows actual value #7623

binoy14 commented Oct 15, 2024 •

edited

Loading

vercel bot commented Oct 15, 2024 •

edited

Loading

binoy14 commented Oct 15, 2024

binoy14 Oct 15, 2024

github-actions bot commented Oct 15, 2024

binoy14 Oct 15, 2024

github-actions bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

fix(core): boolean value in search shows actual value #7623

fix(core): boolean value in search shows actual value #7623

Conversation

binoy14 commented Oct 15, 2024 • edited Loading

Description

What to review

Testing

Notes for release

vercel bot commented Oct 15, 2024 • edited Loading

binoy14 commented Oct 15, 2024

binoy14 Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 15, 2024

binoy14 Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 15, 2024 • edited Loading

github-actions bot commented Oct 15, 2024 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

binoy14 commented Oct 15, 2024 •

edited

Loading

vercel bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading