Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global perspective picker facelift #7629

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

jordanl17
Copy link
Member

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:41pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:41pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:41pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:41pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:41pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 2:41pm

@jordanl17 jordanl17 marked this pull request as ready for review October 18, 2024 14:29
@jordanl17 jordanl17 requested a review from a team as a code owner October 18, 2024 14:29
@jordanl17 jordanl17 requested review from juice49 and removed request for a team October 18, 2024 14:29
Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Oct 18, 2024 2:38 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 10s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 42s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 54s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 33s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 10s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 41s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 43s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 38s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 53s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@jordanl17 jordanl17 merged commit c80e628 into corel Oct 18, 2024
59 of 62 checks passed
@jordanl17 jordanl17 deleted the corel-184-picker-facelift branch October 18, 2024 14:39
Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 18 Oct 2024 14:51:01 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 17.2 efps (58ms) 13.5 efps (74ms) +16ms (+27.6%) 🔴
article (body) 61.3 efps (16ms) 59.9 efps (17ms) +0ms (+2.5%)
article (string inside object) 19.2 efps (52ms) 13.8 efps (73ms) +21ms (+39.4%) 🔴
article (string inside array) 14.9 efps (67ms) 11.9 efps (84ms) +17ms (+25.4%) 🔴
recipe (name) 31.3 efps (32ms) 21.3 efps (47ms) +15ms (+46.9%) 🔴
recipe (description) 34.5 efps (29ms) 23.3 efps (43ms) +14ms (+48.3%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.8 efps (68ms) 6.1 efps (165ms) +97ms (+143.7%) 🔴
synthetic (string inside object) 15.5 efps (65ms) 6.3 efps (158ms) +93ms (+144.2%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 58ms 65ms 85ms 192ms 345ms 13.7s
article (body) 16ms 19ms 21ms 144ms 221ms 5.5s
article (string inside object) 52ms 54ms 57ms 228ms 241ms 8.1s
article (string inside array) 67ms 70ms 79ms 188ms 837ms 9.2s
recipe (name) 32ms 35ms 38ms 71ms 22ms 10.2s
recipe (description) 29ms 30ms 37ms 138ms 0ms 6.1s
recipe (instructions) 6ms 8ms 9ms 11ms 0ms 3.2s
synthetic (title) 68ms 73ms 110ms 357ms 1445ms 19.4s
synthetic (string inside object) 65ms 71ms 83ms 400ms 1481ms 10.7s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 74ms 85ms 103ms 286ms 2338ms 16.3s
article (body) 17ms 18ms 24ms 197ms 294ms 5.8s
article (string inside object) 73ms 78ms 92ms 216ms 2146ms 10.6s
article (string inside array) 84ms 88ms 100ms 286ms 2940ms 11.7s
recipe (name) 47ms 49ms 52ms 82ms 673ms 11.2s
recipe (description) 43ms 46ms 49ms 107ms 508ms 7.5s
recipe (instructions) 6ms 8ms 10ms 35ms 0ms 3.3s
synthetic (title) 165ms 171ms 182ms 482ms 9322ms 27.1s
synthetic (string inside object) 158ms 164ms 178ms 723ms 8477ms 19.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant