Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tone of navbar derived from current selected release type #7632

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Oct 18, 2024

Description

Screenshot 2024-10-18 at 17 05 01

What to review

Testing

Notes for release

@jordanl17 jordanl17 requested a review from a team as a code owner October 18, 2024 15:23
@jordanl17 jordanl17 requested review from rexxars and removed request for a team October 18, 2024 15:23
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 3:32pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 3:32pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 3:32pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 3:32pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 3:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Oct 18, 2024 3:32pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Oct 18, 2024 3:32 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 13s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 40s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 34s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 39s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 44s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 40s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 53s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 18 Oct 2024 15:45:21 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 15.6 efps (64ms) 12.0 efps (84ms) +20ms (+30.5%) 🔴
article (body) 65.8 efps (15ms) 56.7 efps (18ms) +2ms (+16.1%)
article (string inside object) 17.1 efps (59ms) 13.3 efps (75ms) +17ms (+28.2%) 🔴
article (string inside array) 13.2 efps (76ms) 11.0 efps (91ms) +15ms (+19.7%)
recipe (name) 28.6 efps (35ms) 20.0 efps (50ms) +15ms (+42.9%) 🔴
recipe (description) 32.3 efps (31ms) 21.3 efps (47ms) +16ms (+51.6%) 🔴
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (8ms) +1ms (-/-%)
synthetic (title) 13.8 efps (73ms) 5.7 efps (175ms) +103ms (+141.4%) 🔴
synthetic (string inside object) 15.2 efps (66ms) 6.1 efps (164ms) +98ms (+148.5%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 64ms 70ms 129ms 144ms 501ms 14.6s
article (body) 15ms 19ms 21ms 107ms 153ms 5.4s
article (string inside object) 59ms 65ms 81ms 267ms 411ms 9.0s
article (string inside array) 76ms 82ms 125ms 244ms 1094ms 10.3s
recipe (name) 35ms 37ms 41ms 69ms 21ms 8.9s
recipe (description) 31ms 33ms 52ms 153ms 6ms 6.4s
recipe (instructions) 7ms 8ms 10ms 19ms 0ms 3.3s
synthetic (title) 73ms 75ms 85ms 386ms 1789ms 15.7s
synthetic (string inside object) 66ms 69ms 76ms 534ms 1082ms 9.9s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 84ms 96ms 108ms 214ms 2664ms 16.6s
article (body) 18ms 21ms 30ms 318ms 495ms 6.0s
article (string inside object) 75ms 83ms 93ms 312ms 2674ms 11.5s
article (string inside array) 91ms 98ms 112ms 322ms 3301ms 12.4s
recipe (name) 50ms 53ms 61ms 123ms 951ms 11.0s
recipe (description) 47ms 49ms 51ms 88ms 707ms 7.9s
recipe (instructions) 8ms 9ms 11ms 13ms 0ms 3.4s
synthetic (title) 175ms 183ms 201ms 1162ms 10133ms 26.6s
synthetic (string inside object) 164ms 170ms 181ms 678ms 9515ms 21.1s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@jordanl17 jordanl17 merged commit dfdf6a7 into corel Oct 18, 2024
61 of 63 checks passed
@jordanl17 jordanl17 deleted the corel-186-navbar-tone branch October 18, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant