Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): export BetaFeatures and ScheduledPublishing types #7659

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix(core): export BetaFeatures and ScheduledPublishing types #7659

merged 1 commit into from
Nov 4, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

Export types BetaFeatures and ScheduledPublishing from sanity

External libraries, like sanity-typed need the types used in defineConfig to be exported.

fixes: #7637

What to review

Any side effect to consider?

Testing

No new functionality added, no tests added.

Notes for release

n/a

@pedrobonamin pedrobonamin requested a review from a team as a code owner October 23, 2024 07:53
@pedrobonamin pedrobonamin requested review from ricokahler and removed request for a team October 23, 2024 07:53
@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 8:11am
performance-studio ✅ Ready (Inspect) Visit Preview Oct 23, 2024 8:11am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 8:11am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 8:11am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 8:11am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 8:11am

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Oct 23, 2024 8:07 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 47s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 38s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 41s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 16s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 35s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor

⚡️ Editor Performance Report

Updated Wed, 23 Oct 2024 08:10:14 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 16.7 efps (60ms) 17.5 efps (57ms) -3ms (-5.0%) ✅
article (body) 65.4 efps (15ms) 65.6 efps (15ms) -0ms (-/-%) ✅
article (string inside object) 18.5 efps (54ms) 18.2 efps (55ms) +1ms (+1.9%) ✅
article (string inside array) 14.4 efps (70ms) 14.7 efps (68ms) -2ms (-2.2%) ✅
recipe (name) 30.8 efps (33ms) 30.3 efps (33ms) +1ms (+1.5%) ✅
recipe (description) 33.3 efps (30ms) 34.5 efps (29ms) -1ms (-3.3%) ✅
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (7ms) +1ms (-/-%) ✅
synthetic (title) 14.6 efps (69ms) 14.9 efps (67ms) -2ms (-2.2%) ✅
synthetic (string inside object) 15.4 efps (65ms) 15.2 efps (66ms) +1ms (+1.5%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 60ms 64ms 75ms 238ms 397ms 14.2s
article (body) 15ms 17ms 21ms 129ms 249ms 5.4s
article (string inside object) 54ms 57ms 63ms 202ms 252ms 8.6s
article (string inside array) 70ms 75ms 86ms 284ms 1129ms 10.0s
recipe (name) 33ms 36ms 53ms 73ms 14ms 9.3s
recipe (description) 30ms 31ms 36ms 61ms 5ms 6.1s
recipe (instructions) 6ms 7ms 9ms 24ms 0ms 3.2s
synthetic (title) 69ms 73ms 93ms 313ms 1719ms 16.5s
synthetic (string inside object) 65ms 68ms 81ms 327ms 1202ms 10.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 57ms 62ms 80ms 143ms 359ms 12.9s
article (body) 15ms 18ms 22ms 198ms 263ms 5.3s
article (string inside object) 55ms 58ms 62ms 203ms 229ms 8.3s
article (string inside array) 68ms 72ms 80ms 240ms 1184ms 9.7s
recipe (name) 33ms 36ms 48ms 66ms 10ms 10.1s
recipe (description) 29ms 32ms 39ms 148ms 10ms 6.1s
recipe (instructions) 7ms 9ms 10ms 26ms 0ms 3.3s
synthetic (title) 67ms 71ms 82ms 327ms 1492ms 16.3s
synthetic (string inside object) 66ms 69ms 74ms 301ms 1018ms 9.8s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@saiichihashimoto
Copy link
Contributor

Excited for this, would unblock me!

@pedrobonamin pedrobonamin added this pull request to the merge queue Nov 4, 2024
Merged via the queue into next with commit 9fbebab Nov 4, 2024
67 checks passed
@pedrobonamin pedrobonamin deleted the sgh-183 branch November 4, 2024 15:45
bjoerge added a commit that referenced this pull request Nov 5, 2024
@bjoerge
Merge branch 'next' into corel
49310e8 
* next:
  chore(deps): dedupe pnpm-lock.yaml (#7752)
  chore(deps): update react monorepo (#7753)
  fix(deps): update dependency react-rx to ^4.1.3 (#7744)
  fix(deps): update dependency @sanity/ui to ^2.8.19 (#7742)
  fix(deps): update dependency @portabletext/editor to ^1.5.4 (#7737)
  fix(deps): update dependency @sanity/presentation to v1.17.8 (#7743)
  test(codegen): migrate codegen tests to vitest (#7741)
  fix: invalid locale namespace specified for create (#7732)
  chore(deps): update dependency @sanity/prettier-config to ^1.0.3 (#7733)
  fix(deps): update dependency react-rx to ^4.1.1 (#7739)
  fix(deps): update dependency groq-js to ^1.14.0 (#7738)
  test(cli): migrate cli tests to vitest (#7731)
  fix(core): export BetaFeatures and ScheduledPublishing types (#7659)
  chore(test-studio): update dependency @portabletext/editor to ^1.4.1 (#7734)
  fix(deps): update dependency @portabletext/editor to ^1.4.1 (#7735)
  fix(deps): update dependency @portabletext/editor to ^1.4.0 (#7729)
  fix(deps): update dependency @sanity/ui to ^2.8.18 (#7730)
  fix(deps): Update dev-non-major (#7724)
  fix(deps): update dependency @sanity/ui to ^2.8.17 (#7725)
  fix(deps): update dependency @portabletext/editor to ^1.3.0 (#7727)
jordanl17 pushed a commit that referenced this pull request Nov 5, 2024
@pedrobonamin @jordanl17
fix(core): export BetaFeatures and ScheduledPublishing types (#7659)
f2b1566
bjoerge added a commit that referenced this pull request Nov 5, 2024
@bjoerge
Merge branch 'next' into corel
9745162 
* next: (49 commits)
  v3.63.0
  chore(scripts): reordering blocks in release notes template script (#7758)
  chore(deps): update dependency babel-plugin-react-compiler to v19 (#7755)
  fix(deps): Update dev-non-major (#7736)
  chore(deps): dedupe pnpm-lock.yaml (#7752)
  chore(deps): update react monorepo (#7753)
  fix(deps): update dependency react-rx to ^4.1.3 (#7744)
  fix(deps): update dependency @sanity/ui to ^2.8.19 (#7742)
  fix(deps): update dependency @portabletext/editor to ^1.5.4 (#7737)
  fix(deps): update dependency @sanity/presentation to v1.17.8 (#7743)
  test(codegen): migrate codegen tests to vitest (#7741)
  fix: invalid locale namespace specified for create (#7732)
  chore(deps): update dependency @sanity/prettier-config to ^1.0.3 (#7733)
  fix(deps): update dependency react-rx to ^4.1.1 (#7739)
  fix(deps): update dependency groq-js to ^1.14.0 (#7738)
  test(cli): migrate cli tests to vitest (#7731)
  fix(core): export BetaFeatures and ScheduledPublishing types (#7659)
  chore(test-studio): update dependency @portabletext/editor to ^1.4.1 (#7734)
  fix(deps): update dependency @portabletext/editor to ^1.4.1 (#7735)
  fix(deps): update dependency @portabletext/editor to ^1.4.0 (#7729)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricokahler ricokahler ricokahler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export types ScheduledPublishingPluginOptions and BetaFeatures
3 participants
@pedrobonamin @saiichihashimoto @ricokahler