feat(releases): global perspective release type grouped menu #7677

jordanl17 · 2024-10-28T02:14:40Z

Description

What to review

Testing

Notes for release

… release types

…ed perspective layers

…ed perspective in global menu

…icator

vercel · 2024-10-28T02:14:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 2:41am
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 2:41am
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 2:41am
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 2:41am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 2:41am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Oct 28, 2024 2:41am

…ting release type section component

github-actions · 2024-10-28T02:32:12Z

No changes to documentation

github-actions · 2024-10-28T02:38:20Z

Component Testing Report Updated Oct 28, 2024 2:38 AM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 13s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	13s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	41s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	53s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	27s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	16s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	3m 0s	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 11s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	2m 41s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 43s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	14s	3	9
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	40s	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	28s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	54s	12	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-10-28T02:52:00Z

⚡️ Editor Performance Report

Updated Mon, 28 Oct 2024 02:51:59 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	17.5 efps (57ms)	12.8 efps (78ms)	+21ms (+36.8%)	🔴
article (body)	61.5 efps (16ms)	63.7 efps (16ms)	-1ms (-3.4%)	✅
article (string inside object)	19.6 efps (51ms)	13.5 efps (74ms)	+23ms (+45.1%)	🔴
article (string inside array)	15.6 efps (64ms)	11.5 efps (87ms)	+23ms (+35.9%)	🔴
recipe (name)	29.4 efps (34ms)	19.6 efps (51ms)	+17ms (+50.0%)	🔴
recipe (description)	32.3 efps (31ms)	20.8 efps (48ms)	+17ms (+54.8%)	🔴
recipe (instructions)	99.9+ efps (6ms)	99.9+ efps (6ms)	+0ms (-/-%)	✅
synthetic (title)	13.7 efps (73ms)	5.6 efps (178ms)	+105ms (+143.8%)	🔴
synthetic (string inside object)	14.5 efps (69ms)	5.8 efps (173ms)	+104ms (+150.7%)	🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	57ms	59ms	66ms	222ms	382ms	13.0s
article (body)	16ms	18ms	22ms	79ms	243ms	5.3s
article (string inside object)	51ms	53ms	60ms	131ms	232ms	8.1s
article (string inside array)	64ms	66ms	73ms	221ms	816ms	9.1s
recipe (name)	34ms	37ms	60ms	74ms	20ms	9.5s
recipe (description)	31ms	35ms	42ms	117ms	0ms	6.3s
recipe (instructions)	6ms	8ms	9ms	23ms	0ms	3.2s
synthetic (title)	73ms	77ms	84ms	413ms	1723ms	15.8s
synthetic (string inside object)	69ms	73ms	99ms	200ms	1589ms	10.4s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	78ms	86ms	249ms	534ms	4481ms	18.7s
article (body)	16ms	19ms	29ms	238ms	313ms	5.6s
article (string inside object)	74ms	82ms	162ms	462ms	3817ms	13.0s
article (string inside array)	87ms	94ms	115ms	564ms	4645ms	14.4s
recipe (name)	51ms	58ms	215ms	250ms	2784ms	14.6s
recipe (description)	48ms	52ms	60ms	101ms	1904ms	9.9s
recipe (instructions)	6ms	8ms	9ms	21ms	0ms	3.4s
synthetic (title)	178ms	193ms	211ms	500ms	12890ms	30.6s
synthetic (string inside object)	173ms	188ms	338ms	874ms	13486ms	25.5s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

jordanl17 added 6 commits October 27, 2024 20:08

feat(releases): new global perspective menu item component to support…

991c15b

… release types

Merge branch 'corel' into corel-global-perspective-facelift

ff1aea0

feat(releases): supporting styling for left-track indicator on select…

c3c580f

…ed perspective layers

fix(releases): resolving issue where animation not applied to publish…

5af0806

…ed perspective in global menu

refactor(releases): sorting global perspective menu items

56eaa2d

refactor(releases): further tidy to style logic for release layer ind…

8c21649

…icator

jordanl17 changed the base branch from next to corel October 28, 2024 02:14

vercel bot deployed to Preview – performance-studio October 28, 2024 02:18 View deployment

vercel bot deployed to Preview – page-building-studio October 28, 2024 02:18 View deployment

vercel bot deployed to Preview – test-studio October 28, 2024 02:19 View deployment

vercel bot deployed to Preview – test-next-studio October 28, 2024 02:23 View deployment

vercel bot deployed to Preview – test-compiled-studio October 28, 2024 02:26 View deployment

jordanl17 added 2 commits October 28, 2024 02:28

refactor(releases): minor final tidy to global perspective menu; crea…

718164a

…ting release type section component

feat(releases): release table component accepts column style properties

eb92a80

vercel bot deployed to Preview – page-building-studio October 28, 2024 02:33 View deployment

vercel bot deployed to Preview – performance-studio October 28, 2024 02:33 View deployment

vercel bot deployed to Preview – test-studio October 28, 2024 02:34 View deployment

jordanl17 marked this pull request as ready for review October 28, 2024 02:38

jordanl17 requested a review from a team as a code owner October 28, 2024 02:38

jordanl17 requested review from ryanbonial and removed request for a team October 28, 2024 02:38

vercel bot deployed to Preview – test-next-studio October 28, 2024 02:38 View deployment

jordanl17 merged commit e8a5dad into corel Oct 28, 2024
54 of 59 checks passed

jordanl17 deleted the corel-global-perspective-facelift branch October 28, 2024 02:38

vercel bot deployed to Preview – test-compiled-studio October 28, 2024 02:41 View deployment

RitaDias pushed a commit that referenced this pull request Oct 28, 2024

feat(releases): global perspective release type grouped menu (#7677)

a2a03ac

RitaDias pushed a commit that referenced this pull request Oct 28, 2024

feat(releases): global perspective release type grouped menu (#7677)

a017168

RitaDias pushed a commit that referenced this pull request Oct 28, 2024

feat(releases): global perspective release type grouped menu (#7677)

63b1233

RitaDias pushed a commit that referenced this pull request Oct 28, 2024

feat(releases): global perspective release type grouped menu (#7677)

719b0d9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(releases): global perspective release type grouped menu #7677

feat(releases): global perspective release type grouped menu #7677

jordanl17 commented Oct 28, 2024

vercel bot commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024

github-actions bot commented Oct 28, 2024

github-actions bot commented Oct 28, 2024

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

feat(releases): global perspective release type grouped menu #7677

feat(releases): global perspective release type grouped menu #7677

Conversation

jordanl17 commented Oct 28, 2024

Description

What to review

Testing

Notes for release

vercel bot commented Oct 28, 2024 • edited Loading

github-actions bot commented Oct 28, 2024

github-actions bot commented Oct 28, 2024

github-actions bot commented Oct 28, 2024

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

vercel bot commented Oct 28, 2024 •

edited

Loading