Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test @sanity/ui with react compiler #7698

Closed
wants to merge 1 commit into from

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Oct 29, 2024

Just testing the eFPS impact of shipping @sanity/ui with react compiler enabled

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 10:24pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 10:24pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 10:24pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 10:24pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 10:24pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 10:24pm

Copy link

socket-security bot commented Oct 29, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sanity/ui@2.9.0-canary.6 Transitive: environment +26 17.2 MB stipsan

🚮 Removed packages: npm/@sanity/ui@2.8.10

View full report↗︎

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Component Testing Report Updated Oct 29, 2024 10:20 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 39s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 32s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 46s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 18s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 36s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Oct 29, 2024

⚡️ Editor Performance Report

Updated Tue, 29 Oct 2024 22:23:29 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 15.4 efps (65ms) 17.5 efps (57ms) -8ms (-12.3%)
article (body) 53.5 efps (19ms) 58.0 efps (17ms) -1ms (-7.8%)
article (string inside object) 16.4 efps (61ms) 19.2 efps (52ms) -9ms (-14.8%)
article (string inside array) 13.7 efps (73ms) 15.4 efps (65ms) -8ms (-11.0%)
recipe (name) 27.8 efps (36ms) 31.3 efps (32ms) -4ms (-11.1%)
recipe (description) 31.3 efps (32ms) 34.5 efps (29ms) -3ms (-9.4%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (7ms) +1ms (-/-%)
synthetic (title) 14.9 efps (67ms) 14.9 efps (67ms) +0ms (-/-%)
synthetic (string inside object) 14.9 efps (67ms) 15.2 efps (66ms) -1ms (-1.5%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 65ms 69ms 86ms 221ms 743ms 13.7s
article (body) 19ms 22ms 27ms 282ms 424ms 6.2s
article (string inside object) 61ms 66ms 72ms 302ms 523ms 9.3s
article (string inside array) 73ms 78ms 88ms 235ms 1321ms 10.4s
recipe (name) 36ms 39ms 49ms 70ms 0ms 9.0s
recipe (description) 32ms 34ms 42ms 81ms 7ms 6.1s
recipe (instructions) 6ms 8ms 9ms 22ms 0ms 3.2s
synthetic (title) 67ms 73ms 81ms 216ms 1553ms 15.7s
synthetic (string inside object) 67ms 71ms 85ms 519ms 1673ms 10.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 57ms 66ms 77ms 206ms 478ms 13.3s
article (body) 17ms 20ms 37ms 200ms 274ms 5.8s
article (string inside object) 52ms 54ms 61ms 225ms 243ms 8.5s
article (string inside array) 65ms 70ms 75ms 284ms 899ms 9.5s
recipe (name) 32ms 35ms 40ms 82ms 0ms 8.9s
recipe (description) 29ms 31ms 36ms 60ms 0ms 5.8s
recipe (instructions) 7ms 8ms 10ms 41ms 10ms 3.4s
synthetic (title) 67ms 71ms 94ms 356ms 1337ms 14.4s
synthetic (string inside object) 66ms 71ms 119ms 441ms 1585ms 10.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant