Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): avoid literal as const package exports due to etl error #7756

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Nov 5, 2024

Should fix the pnpm etl sanity task that's currently failing in the base branch

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 0:11am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 0:11am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 0:11am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 0:11am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 0:11am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Nov 5, 2024 0:11am

Copy link
Contributor

github-actions bot commented Nov 5, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Component Testing Report Updated Nov 5, 2024 12:10 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 10s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 42s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 43s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 51s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 43s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 58s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Nov 5, 2024

⚡️ Editor Performance Report

Updated Tue, 05 Nov 2024 12:15:15 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.5 efps (61ms) 12.7 efps (79ms) +19ms (+30.6%) 🔴
article (body) 50.4 efps (20ms) 52.1 efps (19ms) -1ms (-3.3%)
article (string inside object) 18.5 efps (54ms) 13.3 efps (75ms) +21ms (+38.9%) 🔴
article (string inside array) 16.1 efps (62ms) 10.7 efps (94ms) +32ms (+50.8%) 🔴
recipe (name) 30.3 efps (33ms) 19.4 efps (52ms) +19ms (+56.1%) 🔴
recipe (description) 33.3 efps (30ms) 21.1 efps (48ms) +18ms (+58.3%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (7ms) +1ms (-/-%)
synthetic (title) 14.7 efps (68ms) 5.7 efps (174ms) +106ms (+155.9%) 🔴
synthetic (string inside object) 15.6 efps (64ms) 6.1 efps (163ms) +99ms (+154.7%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 61ms 69ms 85ms 363ms 739ms 13.5s
article (body) 20ms 22ms 30ms 274ms 418ms 6.4s
article (string inside object) 54ms 57ms 68ms 102ms 327ms 8.4s
article (string inside array) 62ms 69ms 78ms 242ms 833ms 9.4s
recipe (name) 33ms 37ms 60ms 90ms 6ms 8.6s
recipe (description) 30ms 31ms 38ms 137ms 0ms 6.1s
recipe (instructions) 6ms 8ms 9ms 12ms 0ms 3.2s
synthetic (title) 68ms 72ms 80ms 148ms 1745ms 16.2s
synthetic (string inside object) 64ms 68ms 83ms 343ms 1067ms 9.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 79ms 83ms 108ms 438ms 3706ms 18.6s
article (body) 19ms 25ms 59ms 242ms 896ms 7.7s
article (string inside object) 75ms 82ms 90ms 562ms 3481ms 12.1s
article (string inside array) 94ms 109ms 277ms 456ms 4714ms 14.6s
recipe (name) 52ms 60ms 89ms 202ms 2459ms 14.1s
recipe (description) 48ms 54ms 72ms 217ms 1783ms 9.6s
recipe (instructions) 7ms 9ms 10ms 26ms 25ms 3.8s
synthetic (title) 174ms 186ms 438ms 668ms 11147ms 28.4s
synthetic (string inside object) 163ms 183ms 525ms 919ms 11492ms 22.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@bjoerge bjoerge merged commit d670fe9 into corel Nov 5, 2024
64 of 66 checks passed
@bjoerge bjoerge deleted the fix-literal-as-const branch November 5, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant