Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typegen): add support for astro #8098

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat(typegen): add support for astro #8098

merged 1 commit into from
Dec 18, 2024

Conversation

sgulseth
Copy link
Member

@sgulseth sgulseth commented Dec 18, 2024 •
edited
Loading

Description

if a file ends with astro we find all code fences and only attempt to discover queries inside those. We also append .ts to the filename to enable ts with the babel ts preset

What to review

  • Correctness
  • Any test cases missing?

Testing

Added 👍

Notes for release

feat: Add support for discovering queries in .astro files.

Fixes #6965

@sgulseth sgulseth requested a review from a team as a code owner December 18, 2024 19:48
@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 8:37pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 8:37pm
test-next-studio 🛑 Canceled (Inspect) Dec 18, 2024 8:37pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 8:37pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 8:37pm

@sgulseth sgulseth requested a review from stipsan December 18, 2024 19:49
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

Component Testing Report Updated Dec 18, 2024 8:07 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 14s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 42s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 57s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 14s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 39s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 49s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 53s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

stipsan
stipsan approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop whoop!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

⚡️ Editor Performance Report

Updated Wed, 18 Dec 2024 20:10:22 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 22.7 efps (44ms) 23.8 efps (42ms) -2ms (-4.5%) ✅
article (body) 67.6 efps (15ms) 63.3 efps (16ms) +1ms (-/-%) ✅
article (string inside object) 23.8 efps (42ms) 24.7 efps (41ms) -2ms (-3.6%) ✅
article (string inside array) 22.2 efps (45ms) 23.3 efps (43ms) -2ms (-4.4%) ✅
recipe (name) 55.6 efps (18ms) 52.6 efps (19ms) +1ms (+5.6%) ✅
recipe (description) 60.6 efps (17ms) 62.5 efps (16ms) -1ms (-3.0%) ✅
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%) ✅
synthetic (title) 19.2 efps (52ms) 20.0 efps (50ms) -2ms (-3.8%) ✅
synthetic (string inside object) 19.4 efps (52ms) 19.2 efps (52ms) +1ms (+1.0%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 44ms 55ms 67ms 572ms 920ms 11.6s
article (body) 15ms 17ms 20ms 76ms 62ms 5.2s
article (string inside object) 42ms 44ms 50ms 87ms 235ms 7.1s
article (string inside array) 45ms 47ms 51ms 93ms 141ms 7.2s
recipe (name) 18ms 19ms 24ms 37ms 0ms 6.9s
recipe (description) 17ms 18ms 20ms 29ms 0ms 4.4s
recipe (instructions) 5ms 6ms 8ms 26ms 0ms 3.0s
synthetic (title) 52ms 55ms 65ms 259ms 541ms 14.0s
synthetic (string inside object) 52ms 58ms 69ms 424ms 898ms 8.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 42ms 56ms 83ms 573ms 880ms 11.7s
article (body) 16ms 17ms 23ms 143ms 259ms 5.3s
article (string inside object) 41ms 43ms 48ms 201ms 193ms 6.9s
article (string inside array) 43ms 49ms 56ms 164ms 171ms 7.1s
recipe (name) 19ms 21ms 22ms 34ms 0ms 7.1s
recipe (description) 16ms 18ms 20ms 31ms 0ms 4.3s
recipe (instructions) 5ms 6ms 7ms 12ms 0ms 3.0s
synthetic (title) 50ms 54ms 62ms 314ms 609ms 13.8s
synthetic (string inside object) 52ms 55ms 82ms 204ms 410ms 8.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@sgulseth sgulseth added this pull request to the merge queue Dec 18, 2024
Merged via the queue into next with commit fd8e334 Dec 18, 2024
53 of 55 checks passed
@sgulseth sgulseth deleted the feat/support-astro branch December 18, 2024 20:33
@vercel vercel bot temporarily deployed to Preview – test-next-studio December 18, 2024 20:37 Inactive
binoy14 pushed a commit that referenced this pull request Dec 18, 2024
@sgulseth @binoy14
feat(typegen): add support for astro (#8098)
10e89f3
bjoerge added a commit that referenced this pull request Dec 19, 2024
@bjoerge
Merge branch 'next' into corel
1adb6e3 
* next: (68 commits)
  fix(deps): update dependency @sanity/icons to ^3.5.5 (#8105)
  fix(deps): update dependency @sanity/ui to ^2.10.12 (#8108)
  fix(deps): update dependency react-rx to ^4.1.10 (#8109)
  chore(deps): update dependency @sanity/tsdoc to v1.0.153 (#8107)
  chore(deps): update typescript-tooling (#8104)
  fix(deps): update dependency @sanity/icons to ^3.5.5 (#8106)
  feat(typegen): add support for astro (#8098)
  chore(deps): update dependency turbo to ^2.3.3 (#8099)
  fix(deps): Update dev-non-major (#8100)
  fix: `WebSocket is closed before the connection is established` warning (#8042)
  v3.68.1
  fix(deps): update dependency @sanity/presentation to v1.19.13 (#8102)
  v3.68.0
  fix: use consistent `framer-motion` semver range (#8094)
  refactor(core): replace `PortableTextEditor` with `EditorProvider` (#8040)
  fix: improve `SanityDefaultPreview` memoization (#8049)
  fix: tooltip position in announcements popup (#8092)
  fix: replace useMemo with useState (#8095)
  fix: replace unsafe `useMemo` with `useState` (#8047)
  fix: replace `React.createElement` with jsx runtime (#8043)
  ...
bjoerge pushed a commit that referenced this pull request Dec 20, 2024
@sgulseth @bjoerge
feat(typegen): add support for astro (#8098)
793a75a
binoy14 pushed a commit that referenced this pull request Dec 20, 2024
@sgulseth @binoy14
feat(typegen): add support for astro (#8098)
92dfc9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stipsan stipsan stipsan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type generation incompatible with Astro
2 participants
@sgulseth @stipsan