Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tasks): fixing typo in empty state title #8143

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Dec 27, 2024

Description

Trivial grammatical mistake fixed in i18n bundle

What to review

Testing

Notes for release

N/A

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 2:55pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 2:55pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 2:55pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 2:55pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Dec 27, 2024 2:55pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Dec 27, 2024 2:51 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 3s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 37s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 27s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 39s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 43s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Dec 27, 2024

⚡️ Editor Performance Report

Updated Mon, 30 Dec 2024 20:22:41 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.3 efps (40ms) 29.4 efps (34ms) -6ms (-13.9%)
article (body) 74.6 efps (13ms) 72.5 efps (14ms) +0ms (-/-%)
article (string inside object) 27.8 efps (36ms) 29.4 efps (34ms) -2ms (-5.6%)
article (string inside array) 26.3 efps (38ms) 27.0 efps (37ms) -1ms (-2.6%)
recipe (name) 52.6 efps (19ms) 57.1 efps (18ms) -2ms (-7.9%)
recipe (description) 57.1 efps (18ms) 62.5 efps (16ms) -2ms (-8.6%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 19.6 efps (51ms) 19.8 efps (51ms) -1ms (-1.0%)
synthetic (string inside object) 19.6 efps (51ms) 21.7 efps (46ms) -5ms (-9.8%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 45ms 66ms 407ms 206ms 9.7s
article (body) 13ms 16ms 18ms 174ms 197ms 4.7s
article (string inside object) 36ms 40ms 46ms 102ms 233ms 6.6s
article (string inside array) 38ms 41ms 45ms 182ms 139ms 6.6s
recipe (name) 19ms 21ms 28ms 41ms 0ms 7.2s
recipe (description) 18ms 19ms 23ms 34ms 0ms 4.5s
recipe (instructions) 6ms 8ms 9ms 15ms 0ms 3.1s
synthetic (title) 51ms 54ms 60ms 158ms 524ms 13.5s
synthetic (string inside object) 51ms 56ms 69ms 515ms 846ms 8.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 34ms 37ms 68ms 174ms 741ms 9.3s
article (body) 14ms 16ms 19ms 139ms 251ms 5.1s
article (string inside object) 34ms 36ms 39ms 56ms 229ms 6.2s
article (string inside array) 37ms 39ms 44ms 78ms 131ms 6.5s
recipe (name) 18ms 20ms 21ms 35ms 0ms 6.3s
recipe (description) 16ms 18ms 19ms 37ms 0ms 4.3s
recipe (instructions) 6ms 8ms 8ms 26ms 0ms 3.1s
synthetic (title) 51ms 53ms 55ms 288ms 426ms 12.1s
synthetic (string inside object) 46ms 49ms 56ms 398ms 807ms 7.8s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@jordanl17 jordanl17 marked this pull request as ready for review December 27, 2024 15:30
@jordanl17 jordanl17 requested a review from a team as a code owner December 27, 2024 15:30
@jordanl17 jordanl17 requested review from ryanbonial and ricokahler and removed request for a team and ryanbonial December 27, 2024 15:30
@jordanl17 jordanl17 added this pull request to the merge queue Jan 2, 2025
Merged via the queue into next with commit 4f08c3d Jan 2, 2025
58 checks passed
@jordanl17 jordanl17 deleted the chore-task-empty-typo branch January 2, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants