-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(presentation): always show all documents in use #8320
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
No changes to documentation |
Component Testing Report Updated Jan 17, 2025 8:16 PM (UTC) ❌ Failed Tests (2) -- expand for details
|
⚡️ Editor Performance ReportUpdated Fri, 17 Jan 2025 21:23:45 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
8016c90
to
455b267
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ❤️
Description
Fixes a regression (I don't know exactly when this regressed) causing only published documents to show up in the list of documents in use in presentation.
What to review
Does it make sense?
Testing
When using the default
Drafts
perspective, notice the before and after (the right hand side is correct, the left hand side only shows documents that are published and have no drafts):For the
Published
perspective it should only filter out documents that only have a draft variant:Notes for release
The Presentation Tool's "Documents in use" pane is now including draft documents, and unpublished documents. So that it actually shows all documents in use, and not just some of them.