Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): removes useObserveDocumentRevisions, it's not used #8465

Merged

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Jan 31, 2025

Description

This hook is not being used at the moment

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner January 31, 2025 11:35
@pedrobonamin pedrobonamin requested review from bjoerge and removed request for a team January 31, 2025 11:35
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 11:42am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 11:42am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 11:42am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 31, 2025 11:42am
test-next-studio ⬜️ Ignored (Inspect) Jan 31, 2025 11:42am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Component Testing Report Updated Jan 31, 2025 11:57 AM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 3s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 59s 4 0 2
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 50s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 32s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 2s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 43s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 31 Jan 2025 11:48:34 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 27.0 efps (37ms) 24.4 efps (41ms) +4ms (+10.8%)
article (body) 67.6 efps (15ms) 67.1 efps (15ms) +0ms (-/-%)
article (string inside object) 26.3 efps (38ms) 26.0 efps (39ms) +1ms (+1.3%)
article (string inside array) 24.7 efps (41ms) 22.5 efps (45ms) +4ms (+9.9%)
recipe (name) 52.6 efps (19ms) 50.0 efps (20ms) +1ms (+5.3%)
recipe (description) 58.8 efps (17ms) 58.8 efps (17ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (6ms) +1ms (-/-%)
synthetic (title) 19.2 efps (52ms) 19.2 efps (52ms) +0ms (-/-%)
synthetic (string inside object) 20.0 efps (50ms) 19.2 efps (52ms) +2ms (+4.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 40ms 44ms 267ms 40ms 10.4s
article (body) 15ms 17ms 27ms 91ms 173ms 5.3s
article (string inside object) 38ms 48ms 60ms 275ms 464ms 7.2s
article (string inside array) 41ms 42ms 48ms 150ms 144ms 6.7s
recipe (name) 19ms 20ms 24ms 38ms 0ms 7.2s
recipe (description) 17ms 18ms 20ms 34ms 0ms 4.3s
recipe (instructions) 5ms 6ms 7ms 25ms 0ms 3.0s
synthetic (title) 52ms 54ms 65ms 109ms 547ms 12.5s
synthetic (string inside object) 50ms 52ms 60ms 103ms 925ms 8.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 47ms 65ms 502ms 788ms 11.4s
article (body) 15ms 17ms 23ms 166ms 180ms 5.3s
article (string inside object) 39ms 42ms 49ms 238ms 274ms 6.9s
article (string inside array) 45ms 46ms 52ms 166ms 280ms 7.2s
recipe (name) 20ms 22ms 24ms 56ms 0ms 8.6s
recipe (description) 17ms 19ms 21ms 36ms 0ms 4.4s
recipe (instructions) 6ms 7ms 9ms 22ms 0ms 3.1s
synthetic (title) 52ms 55ms 63ms 187ms 552ms 12.3s
synthetic (string inside object) 52ms 54ms 65ms 420ms 1010ms 8.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin merged commit 4b54d08 into feat/content-releases Jan 31, 2025
58 checks passed
@pedrobonamin pedrobonamin deleted the remove-useObserveDocumentRevisions branch January 31, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants