Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sanity): remove defunct userMetadata mapping #8476

Merged

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Feb 3, 2025

Description

The userMetadata field is no longer used, nor is it loaded by the app. This commit removes the defunct mapping of this field.

The `userMetadata` field is no longer used, nor is it loaded by the
app. This commit removes the defunct mapping of this field.
@juice49 juice49 requested a review from a team as a code owner February 3, 2025 11:44
@juice49 juice49 requested review from rexxars and removed request for a team February 3, 2025 11:44
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 11:45am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 11:45am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 11:45am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 3, 2025 11:45am
test-next-studio ⬜️ Ignored (Inspect) Feb 3, 2025 11:45am

@juice49 juice49 requested review from pedrobonamin and removed request for rexxars February 3, 2025 11:45
Copy link
Contributor

github-actions bot commented Feb 3, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Component Testing Report Updated Feb 3, 2025 11:51 AM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 4s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 20s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 9s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 30s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 3s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Feb 3, 2025

⚡️ Editor Performance Report

Updated Mon, 03 Feb 2025 11:57:38 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 24.4 efps (41ms) 24.7 efps (41ms) -1ms (-1.2%)
article (body) 67.3 efps (15ms) 67.3 efps (15ms) +0ms (-/-%)
article (string inside object) 26.3 efps (38ms) 26.3 efps (38ms) +0ms (-/-%)
article (string inside array) 24.4 efps (41ms) 21.7 efps (46ms) +5ms (+12.2%)
recipe (name) 52.6 efps (19ms) 50.0 efps (20ms) +1ms (+5.3%)
recipe (description) 58.8 efps (17ms) 55.6 efps (18ms) +1ms (+5.9%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 19.2 efps (52ms) 18.5 efps (54ms) +2ms (+3.8%)
synthetic (string inside object) 18.7 efps (54ms) 19.6 efps (51ms) -3ms (-4.7%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 45ms 87ms 480ms 923ms 12.3s
article (body) 15ms 19ms 48ms 161ms 210ms 5.6s
article (string inside object) 38ms 41ms 43ms 58ms 136ms 6.6s
article (string inside array) 41ms 44ms 50ms 160ms 396ms 7.1s
recipe (name) 19ms 21ms 23ms 53ms 0ms 7.1s
recipe (description) 17ms 19ms 21ms 47ms 0ms 4.5s
recipe (instructions) 5ms 7ms 8ms 32ms 0ms 3.1s
synthetic (title) 52ms 55ms 63ms 320ms 681ms 12.6s
synthetic (string inside object) 54ms 58ms 73ms 137ms 439ms 7.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 54ms 66ms 183ms 781ms 11.6s
article (body) 15ms 19ms 35ms 77ms 192ms 5.4s
article (string inside object) 38ms 41ms 44ms 75ms 147ms 6.8s
article (string inside array) 46ms 50ms 55ms 237ms 417ms 7.5s
recipe (name) 20ms 22ms 26ms 39ms 0ms 7.2s
recipe (description) 18ms 19ms 20ms 27ms 0ms 4.5s
recipe (instructions) 5ms 7ms 8ms 9ms 0ms 3.1s
synthetic (title) 54ms 56ms 61ms 453ms 1112ms 13.3s
synthetic (string inside object) 51ms 56ms 66ms 355ms 879ms 8.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@juice49 juice49 merged commit 0dd8dee into feat/content-releases Feb 3, 2025
57 checks passed
@juice49 juice49 deleted the chore/corel/remove-userMetadata-mapping branch February 3, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants