fix(core): add perspective to query cache key to avoid collisions

[cngonzalez]

Description

There was a subtle bug that could happen if you used a nested ResourceProvider with a perspective (or any other way of implicitly getting a perspective) that pointed to the same project and dataset as another ResourceProvider, wherein you might get the wrong query result. You can see this if you run this branch and check the new route in Kitchensink without the queryStore fix, as below:

Every query store is instanced to a project and dataset, and it caches the results of a query. If you were to make the exact same query in a different provider with a different perspective, your "new" perspective would not be saved in the query key, and you would be served the old cached query result with from the "wrong" perspective, because neither query saved their perspective as part of their query key.

(this wasn't a problem with something like useDocument({...documentHandle, perspective}) because all options got memoized into the key)

This PR rectifies this by forcing every query key to have a perspective. It also adds tests and e2e tests. New results below:

What to review

The only significant logic change is in queryStore.ts. Everything else is testing / future-proofing.

• The new PerspectivesRoute component that demonstrates nested ResourceProvider components with different perspectives
• The updated query store implementation that now properly separates cache entries by perspective
• The new e2e test that verifies published panels don't show draft content

Testing

Added a comprehensive e2e test that:

• Creates a published author document
• Creates a draft overlay with modified content
• Verifies that the drafts panel shows the draft content
• Verifies that the published panel shows only the published content

Fun gif

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
sdk-docs	Ready	Preview	Comment	Sep 2, 2025 7:59pm
sdk-kitchensink-react	Ready	Preview	Comment	Sep 2, 2025 7:59pm

[cngonzalez]

• fix(core): add perspective to query cache key to avoid collisions #609 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cngonzalez]

Not related, but the old implementation caused infinite loading due to recalculating the params passed to documentProjection. That might be something we want to resolve in the hook itself at a later date, but it was annoying me 😅

[binoy14]

hmm I thought kitchensink was using react 19 and compiler, maybe we removed it

[Copilot]

Pull Request Overview

This PR fixes a query cache collision bug that occurred when using nested ResourceProviders with different perspectives but the same project/dataset. The core issue was that query cache keys didn't include perspective information, causing incorrect cached results to be served across different perspective contexts.

Key changes:

• Added perspective normalization to query cache keys to prevent collisions
• Created comprehensive test coverage for both implicit and explicit perspective scenarios
• Added a demonstration route and e2e tests to verify the fix

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/core/src/query/queryStore.ts	Core fix: normalizes query options to include perspective in cache keys
packages/core/src/query/queryStore.test.ts	Unit tests for perspective-based cache separation
apps/kitchensink-react/src/routes/PerspectivesRoute.tsx	Demo component showing nested ResourceProviders with different perspectives
apps/kitchensink-react/src/AppRoutes.tsx	Route registration for the new perspectives demo
apps/kitchensink-react/src/routes/releases/ReleasesRoute.tsx	Refactored to use memoized projection options
apps/kitchensink-react/e2e/perspectives.spec.ts	E2e test verifying published panels don't show draft content

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[binoy14]

makes sense to me, thanks

[binoy14]

hmm I thought kitchensink was using react 19 and compiler, maybe we removed it