sap_control: Bugfix/passed sid is ignored #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbttmbrg
force-pushed
the
bugfix/passed_sid_is_ignored
branch
from
7d2abf7 to
aa389af
Compare
|
Some merge conflicts may occur here. Sorry |
I will need to rebase and test, but it should be just a matter of shuffling the tasks arround that new list and change one variable name. Thank you |
Signed-off-by: Nicolas Bettembourg <nbettembourg@oxya.com>
Signed-off-by: Nicolas Bettembourg <nbettembourg@oxya.com>
nbttmbrg
force-pushed
the
bugfix/passed_sid_is_ignored
branch
from
aa389af to
25ec333
Compare
sean-freeman
changed the title
marcelmamula
approved these changes
Aug 20, 2025
This was referenced Aug 20, 2025
|
When I get a hold on thus bugfix, I will double check for potential conflicts or enhancements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #38
Using passed_sid to filter the list returned by sap_system_facts and select only the dict with SID=passed_sid