Skip to content

Commit

Permalink
make it compatible with ruby 3, use URI without escaping the value (#30)
Browse files Browse the repository at this point in the history
  • Loading branch information
andypf authored Sep 14, 2023
1 parent f97fd15 commit 6e3fe61
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 3 deletions.
27 changes: 26 additions & 1 deletion docker/Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -1,4 +1,29 @@
FROM keppel.eu-de-1.cloud.sap/ccloud-dockerhub-mirror/library/node:17-alpine
FROM keppel.eu-de-1.cloud.sap/ccloud-dockerhub-mirror/library/ruby:3.2.2-alpine3.17

LABEL source_repository="https://github.com/sapcc/elektron"

RUN apk --no-cache add --update \
git \
curl \
build-base \
--virtual .builddeps \
openssh \
yarn \
bash \
unzip \
jq \
the_silver_searcher \
vim \
shared-mime-info \
python3 \
py3-pip\
ca-certificates \
gcc \
libffi-dev \
python3-dev \
musl-dev \
openssl-dev \
g++ libxml2-dev \
libxslt-dev \
libjpeg-turbo-dev \
zlib-dev
1 change: 1 addition & 0 deletions lib/elektron/middlewares/response_handler.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
require_relative './base'
require 'forwardable'

module Elektron
module Middlewares
Expand Down
2 changes: 1 addition & 1 deletion lib/elektron/utils/uri_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module Elektron
module Utils
module UriHelper
def to_url(path, params)
uri = URI(URI.escape(path))
uri = URI(path)
uri.query = URI.encode_www_form(params) if params && !params.empty?
uri.to_s
end
Expand Down
2 changes: 1 addition & 1 deletion lib/elektron/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Elektron
VERSION = '2.2.2'.freeze
VERSION = '2.2.3'.freeze
end

0 comments on commit 6e3fe61

Please sign in to comment.