Skip to content

Commit

Permalink
Merge pull request #89 from sapcc/pprofapi
Browse files Browse the repository at this point in the history
httpapi: add pprofapi, wrapping net/http/pprof with an authorization hook
  • Loading branch information
SuperSandro2000 authored Aug 31, 2023
2 parents c8365d4 + c78a196 commit 1bcecc1
Showing 1 changed file with 115 additions and 0 deletions.
115 changes: 115 additions & 0 deletions httpapi/pprofapi/pprofapi.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
/*******************************************************************************
*
* Copyright 2023 SAP SE
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You should have received a copy of the License along with this
* program. If not, you may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*******************************************************************************/

// Package pprofapi provides a httpapi.API wrapper for the net/http/pprof
// package. This is in a separate package and not the main httpapi package
// because importing net/http/pprof tampers with http.DefaultServeMux, so
// importing this package is only safe if the application does not use
// the http.DefaultServeMux instance.
package pprofapi

import (
"net/http"
"net/http/pprof"
"os"
"strconv"

"github.com/gorilla/mux"

"github.com/sapcc/go-bits/httpapi"
"github.com/sapcc/go-bits/httpext"
"github.com/sapcc/go-bits/logg"
)

// API is a httpapi.API wrapping net/http/pprof. Unlike the default facility in
// net/http/pprof, the respective endpoints are only accessible to admin users.
//
// As an extension of the interface provided by net/http/pprof, the additional
// endpoint `GET /debug/pprof/exe` responds with the process's own executable.
// This can be given to `go tool pprof` when processing any of the pprof
// reports obtained through the other endpoints.
type API struct {
IsAuthorized func(r *http.Request) bool
}

// AddTo implements the httpapi.API interface.
func (a API) AddTo(r *mux.Router) {
if a.IsAuthorized == nil {
panic("API.AddTo() called with IsAuthorized == nil!")
}

r.Methods("GET").Path("/debug/pprof/{operation}").HandlerFunc(a.handler)
}

func (a API) handler(w http.ResponseWriter, r *http.Request) {
httpapi.IdentifyEndpoint(r, "/debug/pprof/:operation")
httpapi.SkipRequestLog(r)
if !a.IsAuthorized(r) {
http.Error(w, "forbidden", http.StatusForbidden)
return
}

switch mux.Vars(r)["operation"] {
default:
pprof.Index(w, r)
case "cmdline":
pprof.Cmdline(w, r)
case "profile":
pprof.Profile(w, r)
case "symbol":
pprof.Symbol(w, r)
case "trace":
pprof.Trace(w, r)
case "exe":
//Custom addition: To run `go tool pprof`, we need the executable that
//produced the pprof output. It is possible to exec into the container to
//copy the binary file out, or to unpack the image, but since we already
//obtain the pprof file via HTTP, it's more convenient to obtain the binary
//over the same mechanism.
dumpOwnExecutable(w)
}
}

func dumpOwnExecutable(w http.ResponseWriter) {
path, err := os.Executable()
if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
buf, err := os.ReadFile(path)
if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}

w.Header().Set("Content-Type", "application/octet-stream")
w.Header().Set("Content-Length", strconv.Itoa(len(buf)))
w.WriteHeader(http.StatusOK)
_, err = w.Write(buf)
if err != nil {
logg.Error("while writing response body during GET /debug/pprof/exe: %s", err.Error())
}
}

// IsRequestFromLocalhost checks whether the given request originates from
// `127.0.0.1` or `::1`. It satisfies the interface of API.IsAuthorized.
func IsRequestFromLocalhost(r *http.Request) bool {
ip := httpext.GetRequesterIPFor(r)
return ip == "127.0.0.1" || ip == "::1"
}

0 comments on commit 1bcecc1

Please sign in to comment.