gopherpolicy: remove explicit YAML dependency #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majewsky
requested review from
SuperSandro2000,
VoigtS and
Nuckal777
as code owners
Callers can still support policy.yaml files, but they have to explicitly provide a YAML parser function of their choice.
majewsky
force-pushed
the
gopherpolicy-remove-strict-yaml-dep
branch
from
1ff1c69
to
918991c
Compare
SuperSandro2000
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callers can still support policy.yaml files, but they have to explicitly provide a YAML parser function of their choice.
The change in package gopherpolicy is explicitly designed to be loud and obvious when Renovate tries to update, because the function signature changes. Unfortunately, I did not see a good way to make the change in package liquidapi similarly loud and obvious. But since this currently only affects Limes (which is under my control) and liquid-ceph (which we have a direct line of communication to), this ought to be manageable.